From nobody Mon Mar 30 17:01:06 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fkyFY4XVMz6X3j7; Mon, 30 Mar 2026 17:01:21 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fkyFY4Ck8z3QCF; Mon, 30 Mar 2026 17:01:21 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774890081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RsHti/YNEolCE8eN0ClzLBX9WdJSGxHEdnm2qRkC7ak=; b=GW4RCVo+hGq7KtmyhVe0B+hnBLxJDzcay+DfUQYxDB+DfJkjiLYliWNxbZS/ynB4pFAiKm GcE9ACwlEOLctSmzokkx1BqCzRPA80Hmz1Yr3nHyYzUJjCQs5dJTxhszpWctjUX502kEqB YTbXTSdRl3wy7P9l++RT5xps16Ve/J8a3mAcMLyWr1y51eMM+lK5aKoNkZIgREHimyHh/U 0RnwDcc5kCRP/4m2ivWl337fle6Te+E3igStEEdg6wTLpC3mkfdfIPxzoYWq8S9ZgY8Ale 2HyhL2FXt25O5toOLfSp3kbbsTvxXl7pCgpVWyNrDuedILOf5z/5uTa10OBlfQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774890081; a=rsa-sha256; cv=none; b=nvsFuj4jdZ27YOKWw9c3t/Ms9ckva28iweI/QSj0bLWuWjlscm3T3z0JpRqF2zkOFXLqre bPgic+Mtm0OuCG73TN+CpYMp7/qYva5FrR/tP+TrnUO12j3yYN/iE0C15sYhq5AfBJsORj UHDI63WYxAH12X37Nf4RSFff2tiWvCuphnreCWsNTYMF/jeKNETCfBhfhjntTBaPrDtlEN AQUNxSS40bdDCZiLlOxxlqu0TaQHA0lfcLIOnplrn1UpDQvwH0UeccrYY836dC7GZx8ktw vPRkTtJPqKoysO9fXd6zkQuNq/h054fOGsofECSbD9vtLyotLyiFUzuQzE9y2Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774890081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RsHti/YNEolCE8eN0ClzLBX9WdJSGxHEdnm2qRkC7ak=; b=qTwGrRJKCk7HU81Y/FKpBoU0GepzyAjbjOyIlSyqpbWpZy7ohd2Aee451p/XaBc7pVDkN2 8FMpUWf+jqj1mhbSmpBjDzeX8QJnTSvyzH7H8ZIn9NcjnXbVsI1Z/0uOPbKmnDMJYr4Ihx EK//irajgxaSsb5yeGaU35nAVkV8TbTwexLT3y4TyBIldbBfHSO/CyeTNNPyGVi+Fxx/jy kwSQ+/iA3Kz1RE0mD2Mb76zr/emmSBP1ZHed//1fSuDLCe7Z9/h7Cjc20R+2E06s+muRXS BDeu8AyHKgNCZjmjz0EQpkpnpodsicPlVEv3QUNhsi0mIK3RGa42pOYN4MOrDQ== Received: from smtpclient.apple (ns1.oxydns.net [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fkyFR57D4zPf1; Mon, 30 Mar 2026 17:01:15 +0000 (UTC) (envelope-from zlei@FreeBSD.org) From: Zhenlei Huang Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_39E69894-D44E-4325-8241-8609EC36E87E" List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.10\)) Subject: Re: git: d9c55b2e8cd6 - main - rss: Enable portions of RSS globally to enable symmetric hashing Date: Tue, 31 Mar 2026 01:01:06 +0800 In-Reply-To: <377ropo1-734p-q318-3p95-2179222sn9oq@mnoonqbm.arg> Cc: Andrew Gallatin , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" To: "Bjoern A. Zeeb" References: <6921c91b.2f53c.60323437@gitrepo.freebsd.org> <377ropo1-734p-q318-3p95-2179222sn9oq@mnoonqbm.arg> X-Mailer: Apple Mail (2.3696.120.41.1.10) --Apple-Mail=_39E69894-D44E-4325-8241-8609EC36E87E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Mar 30, 2026, at 6:41 PM, Bjoern A. Zeeb = wrote: >=20 > On Sat, 22 Nov 2025, Andrew Gallatin wrote: >=20 >> The branch main has been updated by gallatin: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dd9c55b2e8cd6b79f6926278e10a79f1b= cca27a4b >>=20 >> commit d9c55b2e8cd6b79f6926278e10a79f1bcca27a4b >> Author: Andrew Gallatin >> AuthorDate: 2025-11-22 14:29:31 +0000 >> Commit: Andrew Gallatin >> CommitDate: 2025-11-22 14:29:31 +0000 >>=20 >> rss: Enable portions of RSS globally to enable symmetric hashing >>=20 >> We use the fact that all NICs that support hashing are using the >> same hash algorithm and hash key to enable symmetic hashing in >> TCP, where a software version of the same hash is used to >> establish hashes on outgoing connections. >>=20 >> Sponsored by: Netflix >> Reviewed by: adrian, zlei (both early version) >> Differential Revision: https://reviews.freebsd.org/D53089 >> --- >> sys/conf/files | 8 +++--- >> sys/net/rss_config.c | 66 = +++++++++++++++++++++++++++++++------------------- >> sys/net/rss_config.h | 20 +++++++++------ >> sys/netinet/in_rss.c | 3 +++ >> sys/netinet6/in6_rss.c | 3 +++ >> 5 files changed, 63 insertions(+), 37 deletions(-) >>=20 >> diff --git a/sys/conf/files b/sys/conf/files >> index 53fcb80f2b8d..3314274b47a8 100644 >> --- a/sys/conf/files >> +++ b/sys/conf/files >> @@ -4238,10 +4238,10 @@ net/route/route_rtentry.c standard >> net/route/route_subscription.c standard >> net/route/route_tables.c standard >> net/route/route_temporal.c standard >> -net/rss_config.c optional inet rss | inet6 rss >> +net/rss_config.c standard >=20 > Given this relies on toeplitz_hash which is inet | inet6 it doesn't = work for NO-IP > kernels: >=20 > 3 >>> Kernel build for LINT-NOIP started on Mon Mar 30 06:39:36 = UTC 2026 > .. > 36 linking kernel > 37 ld: error: undefined symbol: toeplitz_hash > 38 >>> referenced by rss_config.c > 39 >>> rss_config.o:(rss_hash) > 40 --- kernel --- > 41 *** [kernel] Error code 1 >=20 > Either this needs to be optional inet | inet6 or the topelitz parts = need to be > #if defined(INET6) || defined(INET) in the rss_config.c The net/toeplitz.c is independent with inet or inet6. So maybe it is = better to make it standard ? >=20 >=20 >=20 > Don't ask me why this is visible now but tells something about the = state of LINT > in the last months maybe? >=20 >> net/rtsock.c standard >> net/slcompress.c optional netgraph_vjc >> -net/toeplitz.c optional inet rss | inet6 rss | = route_mpath >> +net/toeplitz.c optional inet | inet6 | = route_mpath >> net/vnet.c optional vimage >> net80211/ieee80211.c optional wlan >> net80211/ieee80211_acl.c optional wlan wlan_acl >=20 > --=20 > Bjoern A. Zeeb = r15:7 Best regards, Zhenlei --Apple-Mail=_39E69894-D44E-4325-8241-8609EC36E87E Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On Mar 30, 2026, at 6:41 PM, Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net> wrote:

On Sat, 22 Nov 2025, Andrew Gallatin wrote:

The = branch main has been updated by gallatin:

URL: https://cgit.FreeBSD.org/src/commit/?id=3Dd9c55b2e8cd6b79f69262= 78e10a79f1bcca27a4b

commit = d9c55b2e8cd6b79f6926278e10a79f1bcca27a4b
Author: =     Andrew Gallatin <gallatin@FreeBSD.org>
AuthorDate: = 2025-11-22 14:29:31 +0000
Commit: =     Andrew Gallatin <gallatin@FreeBSD.org>
CommitDate: = 2025-11-22 14:29:31 +0000

  rss: = Enable portions of RSS globally to enable symmetric hashing

  We use the fact that all NICs that = support hashing are using the
  same hash = algorithm and hash key to enable symmetic hashing in
  TCP, where a software version of the same hash is = used to
  establish hashes on outgoing = connections.

  Sponsored by: = Netflix
  Reviewed by: adrian, zlei (both early = version)
  Differential Revision:  https://reviews.freebsd.org/D53089
---
sys/conf/files =         |  8 +++---
sys/net/rss_config.c   | 66 = +++++++++++++++++++++++++++++++-------------------
sys/net/rss_config.h   | 20 +++++++++------
sys/netinet/in_rss.c   |  3 +++
sys/netinet6/in6_rss.c |  3 +++
5 files = changed, 63 insertions(+), 37 deletions(-)

diff --git a/sys/conf/files b/sys/conf/files
index 53fcb80f2b8d..3314274b47a8 100644
--- = a/sys/conf/files
+++ b/sys/conf/files
@@ = -4238,10 +4238,10 @@ net/route/route_rtentry.c = standard
net/route/route_subscription.c = standard
net/route/route_tables.c = standard
net/route/route_temporal.c = standard
-net/rss_config.c optional = inet rss | inet6 rss
+net/rss_config.c = standard

Given this relies on toeplitz_hash which is inet | inet6 it = doesn't work for NO-IP
kernels:

     3 >>> Kernel build for = LINT-NOIP started on Mon Mar 30 06:39:36 UTC 2026
..
    36 linking kernel
    37 ld: error: undefined symbol: = toeplitz_hash
    38 >>> referenced by = rss_config.c
    39 >>> =             &n= bsp; rss_config.o:(rss_hash)
    40 --- kernel ---
    41 *** [kernel] Error code = 1

Either this = needs to be optional inet | inet6   or the topelitz parts need = to be
#if = defined(INET6) || defined(INET) in the rss_config.c

The net/toeplitz.c is independent with inet = or inet6. So maybe it is better to make it standard ?




Don't ask me = why this is visible now but tells something about the state of = LINT
in the last = months maybe?

net/rtsock.c standard
net/slcompress.c optional netgraph_vjc
-net/toeplitz.c optional inet rss | inet6 rss | = route_mpath
+net/toeplitz.c optional inet | inet6 | = route_mpath
net/vnet.c optional vimage
net80211/ieee80211.c optional wlan
net80211/ieee80211_acl.c optional wlan wlan_acl

-- Bjoern A. = Zeeb =             &n= bsp;           &nbs= p;            =             &n= bsp;  r15:7

Best regards,
Zhenlei

= --Apple-Mail=_39E69894-D44E-4325-8241-8609EC36E87E--