From nobody Sat Oct 4 20:24:21 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cfH7T4P6Kz69mm0; Sat, 04 Oct 2025 20:24:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cfH7T3nXSz41nb; Sat, 04 Oct 2025 20:24:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759609461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IGJeK16hAeAgXhgpuOqBeYhPj5OAsc9w7SblBG/WPBc=; b=EVRlja5hg9hyAsWTQ+ZIK6aDcOU+kMEkYj03uUUXAiJXsKqBFsdsxl5ZpvQNdn4gdl/fP6 k0Mj2m5Xc/NQZdRNFaqdH2ZZQW+En9pUDrOaSe+SiNPieZ/xvDcydne1EHy0j8axe9/FaT hsY4plGWMu9RzxlAfJiqoeIh7tvs4uUWKInL97IStwtrcKjVtTv/Sp7TR7WiMavAca8Vz6 O1vzEH7IgS+PW+k1dY5HTBL1Yr7t1NJIioi9rqkQRc+uwJH+8yA4MlSeMjDsAEGNSSyRAI eVsjJVYNtI5DQrNlPzEYVdsRTk2O0urKez3YrlM0r5kHx3UtASp49OXHKEZS3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759609461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IGJeK16hAeAgXhgpuOqBeYhPj5OAsc9w7SblBG/WPBc=; b=jDoW9lJO98+dqCqXnQ4BlHvMJ6srZU+iBGstK9iijSxHNhTIrjeCmcBLyI7elst5qQ5ddT Q+DGar+EIjbx3oBjJs/6dhZwQi0jZ4Idh5y+1pyTvBUCgUZeIHdMqZzTQHUlW8hoT6/E/L YPaM1u9c3JNba3g8HrF6LNLeUoPeXonq0QcQOJlo/7rXQ0FcOJXEZQAcT6mBu5cSFP4X5Y n6hBTp87ssXnJA0Z48fP0adp8iV+yJG1IUxLALAHMAksXmZKhkCmYTh714hAgvjtlbiWLe dZcrV6wp1QsfGOtmGBGISKxOKiUd0i91UpHHCaL1md79I5KSYhTmHgAUTsh2bg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759609461; a=rsa-sha256; cv=none; b=HP248ZGmR5Y4B+AGO0Re35Vp9Nl+JiuHwNT4DSf5ElMx0oiiJ7kR+CbLTRmz/lvQI9cN7P 7ndV3WUIvG5BFAHhcEhMXBolaVEId9wO2HMxlvySUPXRZqhGLa7AvdGs/h2iyDDV+IrsHX rpBoAjGlCRRc+t5IMs4mYfAn11sJzNKQScmx4fWp0qj+8xN0bRj5rpq3dT8yyVtproNgXV Q37SkMRbAxNRB6Hzn6YwWBXLvRZA5PGkdBZPRRIADS2NEuxJScwT3+yR5exQYQLAOtAKc3 Ur9QyJeuoBxxYpfmR+gZuIL8oPNGNFmdoZ60pTiwX5/UusDu9OPi6SYVYhfjeA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cfH7T34nbzxK4; Sat, 04 Oct 2025 20:24:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 594KOLFc073505; Sat, 4 Oct 2025 20:24:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 594KOLVU073502; Sat, 4 Oct 2025 20:24:21 GMT (envelope-from git) Date: Sat, 4 Oct 2025 20:24:21 GMT Message-Id: <202510042024.594KOLVU073502@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Eric van Gyzen Subject: git: 01b0690c495e - main - if_vmx: fix panic during kldload List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vangyzen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 01b0690c495e1043a72cae9ee945f9f2c2adc216 Auto-Submitted: auto-generated The branch main has been updated by vangyzen: URL: https://cgit.FreeBSD.org/src/commit/?id=01b0690c495e1043a72cae9ee945f9f2c2adc216 commit 01b0690c495e1043a72cae9ee945f9f2c2adc216 Author: Eric van Gyzen AuthorDate: 2025-10-04 12:23:41 +0000 Commit: Eric van Gyzen CommitDate: 2025-10-04 15:20:00 +0000 if_vmx: fix panic during kldload Just like vmxnet3_intr_disable_all, iflib may invoke this routine before vmxnet3_attach_post() has run, which is before the top-level shared data area is initialized and the device made aware of it. MFC after: 1 week Sponsored by: Dell Inc. --- sys/dev/vmware/vmxnet3/if_vmx.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sys/dev/vmware/vmxnet3/if_vmx.c b/sys/dev/vmware/vmxnet3/if_vmx.c index 62b5f313a137..1a314ca6660e 100644 --- a/sys/dev/vmware/vmxnet3/if_vmx.c +++ b/sys/dev/vmware/vmxnet3/if_vmx.c @@ -2056,7 +2056,12 @@ vmxnet3_update_admin_status(if_ctx_t ctx) struct vmxnet3_softc *sc; sc = iflib_get_softc(ctx); - if (sc->vmx_ds->event != 0) + /* + * iflib may invoke this routine before vmxnet3_attach_post() has + * run, which is before the top level shared data area is + * initialized and the device made aware of it. + */ + if (sc->vmx_ds != NULL && sc->vmx_ds->event != 0) vmxnet3_evintr(sc); vmxnet3_refresh_host_stats(sc);