From owner-freebsd-arch@FreeBSD.ORG Sun Mar 23 01:36:17 2008 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D3911065673; Sun, 23 Mar 2008 01:36:17 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id C01808FC1A; Sun, 23 Mar 2008 01:36:16 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [10.0.1.200] (cpe-24-94-72-120.hawaii.res.rr.com [24.94.72.120]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id m2N1aAYq026125; Sat, 22 Mar 2008 21:36:11 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Sat, 22 Mar 2008 15:37:23 -1000 (HST) From: Jeff Roberson X-X-Sender: jroberson@desktop To: Matthew Dillon In-Reply-To: <200803230104.m2N14xlf026184@apollo.backplane.com> Message-ID: <20080322153658.K910@desktop> References: <20080322105145.GA41672@team.vega.ru> <20080322135637.Y6961@fledge.watson.org> <200803230104.m2N14xlf026184@apollo.backplane.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: arch@freebsd.org, Robert Watson Subject: Re: Disposal of a misleading M_TRYWAIT X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Mar 2008 01:36:17 -0000 On Sat, 22 Mar 2008, Matthew Dillon wrote: > > :> Since the advent of MBUMA in FreeBSD (whatever), M_TRYWAIT has meant > :> M_WAITOK. (The reason for M_TRYWAIT itself was that an original mbuf's > :> M_WAIT could return NULL.) > :> > :.. > : > :This seems reasonable to me for exactly the reasons you stte. We might > :simultaneously want to complete the M_DONTWAIT -> M_NOWAIT conversion. And > :you can then remove the XXX comment in mbuf.h about phasing out M_TRYWAIT and > :M_DONTWAIT. :-) > : > :Robert N M Watson > > The real issue is the fact that both the kernel malloc and the mbuf > allocation APIs are using the same M_ prefix for their flags. > > We converted our mbuf allocator flags (aka M_DONTWAIT, M_TRYWAIT, M_WAIT) > from M_ to MB_ and the code became a whole lot easier to read. > > I would not recommend converting the mbuf allocator to actually *USE* > kernel malloc flags. The problem there is that you then have no clear > delineation between M_ flags supported by malloc and M_ flags supported > by the mbuf allocator. They have been the same allocator for some time now. It makes more sense for them to use the same flags. Jeff > > -Matt > > _______________________________________________ > freebsd-arch@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" >