Date: Sun, 16 Dec 2012 12:56:16 +0100 From: =?UTF-8?B?TWFyY28gQnLDtmRlcg==?= <marco.broeder@gmx.eu> To: Ruslan Makhmatkhanov <cvs-src@yandex.ru> Cc: "Jason E. Hale" <jhale@freebsd.org>, bug-followup@freebsd.org, freebsd-ports@freebsd.org Subject: Re: [@ ports committers] ports/173531 Message-ID: <50CDB6E0.4020404@gmx.eu> In-Reply-To: <50CDAF9F.5070601@yandex.ru> References: <50CD99F2.4010205@gmx.eu> <50CDA9A7.7010401@yandex.ru> <50CDAB84.5050701@yandex.ru> <3096099.yLIANgpWSo@mocha.verizon.net> <50CDAF9F.5070601@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig9ECDA3C8AC995544F1E4437A
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On 16.12.2012 12:25, Ruslan Makhmatkhanov wrote:
> Jason E. Hale wrote on 16.12.2012 15:13:
>> On Sunday, December 16, 2012 15:07:48 Ruslan Makhmatkhanov wrote:
>>> Ruslan Makhmatkhanov wrote on 16.12.2012 14:59:
>>>> Hi Marco,
>>>>
>>>> Marco Br=C3=B6der wrote on 16.12.2012 13:52:
>>>>> Hi,
>>>>>
>>>>> could a ports committer take ports/173531 pr, please? It is unassig=
ned
>>>>> for
>>>>> over a month, now.
>>>>>
>>>>> Thank you very much!
>>>>
>>>> Please review patch attached. I changed some things in your patch:
>>>> - using OPTIONSFILE instead of UNIQUENAME (it's common practice to f=
ix
>>>>
>>>> things like that)
>>>>
>>>> - limit to python 2.x (dulwich is not python 3.x-aware yet)
>>>> - tab -> space change in pkg-descr:WWW (style bug)
>>>> - remove DOCS_DESC (we have generic description in bsd.options.desc.=
mk)
>>>> - use PYTHON_CMD instead of ``/usr/bin/env python'' (to make sure it=
>>>>
>>>> will be runned with the same python branch, that it was built wi=
th)
>>>>
>>>> Please let me know if you agree with the changes, and I commit the
>>>> update shortly.
>>>>
>>>> PS. Surely, it builds fine with this patch.
>>>
>>> Oops, I see that this pr was taken by jhale already :)
>>
>> Ruslan,
>>
>> If you want to take this that is fine with me...I haven't started work=
ing on
>> it yet and it seems you have looked into it already.
>>
>>> One more thing - PORTDOCS should be defined uncoditionally, but
>>> installed conditionally:
>>>
>>> +.if ${PORT_OPTIONS:MDOCS}
>>> +PORTDOCS=3D AUTHORS COPYING HACKING NEWS README introduction.txt \
>>> + object-store.txt protocol.txt remote.txt repo.txt
>>> .endif
>>>
>> COPYING should be removed here too. LICENSE is already defined.
>>
>>> This condition is not necessary.
>=20
> Ok, both done (take-pr and COPYING). Thanks. Awaiting of maintainer's=20
> response.
>=20
I reviewed and tested your changes. I am fine with all of it. Please comm=
it.
Many thanks for your help and comments!
--=20
Kind regards
--------------enig9ECDA3C8AC995544F1E4437A
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIcBAEBCAAGBQJQzbcCAAoJEEjQ6Txo1AoUENUQAJMgZVrwd9AUDrRRwCfcASP3
5GPFMQfWIIpy3g0nPfdZMEhvIc/Hnc4wuC3Dct+g0sf8CBmDJeB+CKHxktY3KfSf
m0JgpHavw6pvdR6C1fc4Mh2EhOmA0kam+VVusdpzGEX3w2uQ5JuJWL6jHNgMAsjq
QfOXMNqHwTwA+A+vJ6lcKh4h0qJUbp7MLUZKnAg7GtndmJxPR7j1tOIiJltgzS9D
IFTKYHAvagfnzKQ+MO6AXuAoGBURMAX/PACwBGNs7X6G+zXdzAntAo+Anp7ABfxe
0jy3LtqOvoejyPWwmlbvmRE55bAihfPqNeyUmBMZ7hg3xiihqST8WddxmNFdYTJI
7tkkSRykIO124GGkWmzPZg5t78UZpB3qQRXDjthG/xuETq+Df3DD+i7yrMZKUoax
QR5euqjk7A6Lq1OWkwZhiWnAtaNFAxEM63ukciH+Q3zYqtac4XR482iv2UcbDgX6
nUXORa742RKICfv0IgaloM7ovj0V8DIh6khKXVOOyRW2ns3WriMatS5hsJjn4kK5
PyxFXNn8ARmPwnRkJHJClM1YotRR8Fy0/tHVBeWdcwaF0mFV0IudLVFwVYCJPCiT
bpJD/PVYgLSX8AIfCToXuDfrHjp/rSB0t34qYa/TQ6jp0MzlH6lN2A4BIB9f4PP3
HznqQXu8fUeLsMnrKR4v
=DdVw
-----END PGP SIGNATURE-----
--------------enig9ECDA3C8AC995544F1E4437A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50CDB6E0.4020404>