From owner-cvs-all Mon Feb 4 8:41:39 2002 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 5F96037B416; Mon, 4 Feb 2002 08:41:29 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id ECB885343; Mon, 4 Feb 2002 17:41:27 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Takanori Saneto Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_ssh pam_ssh.c References: <200201241726.g0OHQSN97700@freefall.freebsd.org> <200202041620.g14GK5R06184@muse.sanewo.dyn.to> From: Dag-Erling Smorgrav Date: 04 Feb 2002 17:41:27 +0100 In-Reply-To: <200202041620.g14GK5R06184@muse.sanewo.dyn.to> Message-ID: Lines: 15 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Takanori Saneto writes: > This commit seems to make xdm fail to communicate with ssh-agent. > > In pam_ssh.so, communication socket with ssh-agent is obtained by > ssh_get_authentication_connection, which requires specific information > (SSH_AGENT_xxx) should be in the process's environment. Ah, that's why that putenv() was there. I'd say libssh is broken; there should be a way to pass ssh-agent parameters explicitly to ssh_get_authentication_connection(), rather than through the environment. Your patch is a hack, but a good one. Thank you. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message