Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 May 2020 07:17:03 -0700
From:      Cy Schubert <Cy.Schubert@cschubert.com>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        Cy Schubert <cy@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r535079 - head/devel/bitkeeper
Message-ID:  <202005141417.04EEH3Rv008650@slippy.cwsent.com>
In-Reply-To: <20200513062018.GA276@FreeBSD.org>
References:  <202005130230.04D2U152022548@repo.freebsd.org>  <20200513062018.GA276@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20200513062018.GA276@FreeBSD.org>, Alexey Dokuchaev writes:
> On Wed, May 13, 2020 at 02:30:01AM +0000, Cy Schubert wrote:
> > New Revision: 535079
> > URL: https://svnweb.freebsd.org/changeset/ports/535079
> > 
> > Log:
> >   Supply a symlink to ${LOCALBASE}/bitkeeper/bk in ${LOCALBASE}/bin.
> > 
> > ...
> > @@ -28,5 +29,8 @@ ALL_TARGET= p
> >  
> >  do-build:
> >  	@(cd ${WRKSRC}; ${MAKE_CMD} ${ALL_TARGET})
> > +
> > +post-install:
> > +	@cd ${STAGEDIR}${PREFIX}/bin/ && ${LN} -s ../bitkeeper/bk
>
> This is kind of installation command (it adds new file), so it should not
> be muted.  Also, you don't need "cd" which only makes it harder to read:
>
> 	${LN} -s ../bitkeeper/bk ${STAGEDIR}${PREFIX}/bin

Thanks. I'll fix that.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

	The need of the many outweighs the greed of the few.







Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202005141417.04EEH3Rv008650>