From owner-freebsd-current@FreeBSD.ORG Mon Sep 8 08:14:26 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A91CE16A4E4 for ; Mon, 8 Sep 2003 08:14:26 -0700 (PDT) Received: from spider.deepcore.dk (cpe.atm2-0-56339.0x50c6aa0a.abnxx2.customer.tele.dk [80.198.170.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B2E143F93 for ; Mon, 8 Sep 2003 08:14:24 -0700 (PDT) (envelope-from sos@spider.deepcore.dk) Received: from spider.deepcore.dk (localhost [127.0.0.1]) by spider.deepcore.dk (8.12.9/8.12.9) with ESMTP id h88FEIIo045760; Mon, 8 Sep 2003 17:14:18 +0200 (CEST) (envelope-from sos@spider.deepcore.dk) Received: (from sos@localhost) by spider.deepcore.dk (8.12.9/8.12.9/Submit) id h88FEHFl045759; Mon, 8 Sep 2003 17:14:17 +0200 (CEST) From: Soren Schmidt Message-Id: <200309081514.h88FEHFl045759@spider.deepcore.dk> In-Reply-To: <16220.25305.234322.831546@canoe.dclg.ca> To: David Gilbert Date: Mon, 8 Sep 2003 17:14:17 +0200 (CEST) X-Mailer: ELM [version 2.4ME+ PL99f (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=ISO-8859-1 X-mail-scanned: by DeepCore Virus & Spam killer v1.3 cc: freebsd-current@FreeBSD.ORG Subject: Re: patch for ATAng bug X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2003 15:14:26 -0000 It seems David Gilbert wrote: > Soren> Uhm, I'm working on finding the real problem, and I'd like that > Soren> to be the solution. However the above may be a good workaround > Soren> for those bitten by this... > > Well... is it not possible for malicious hardware to claim to have > zero blocks (by claiming one of it's parameters is zero)? Obviously > it is now. Some of the other crashing complaints (complaints of > crashing only without media in a zip drive, for instance) seem > similar. Hmm, well I dont know of any "malicious hardware" masqurading as ATA disks actually, but that is a point to consider. The ZIP is not an ATA device and doesn't panic the atapi-fd driver neither with nor without a media inserted... > I agree that the real problem in my instance is that the phantom drive > shows up. If I can be any help on that issue, I'd be happy to boot > test code. I've committed code that shoudl fix some of there phantom drives.. > But my question is: would the same parameters passed to ad_print() > result from a pathalogical device (a broken compact flash, hard disk > or whathaveyou)? I put the fix in ad_attach() because I felt that > some other code might break ... but shouldn't we at least protect the > divide-by-zero ... or better reject devices of size zero at this > point. I can't imagine that zero sizes devices are very useful for > storing things. I've newer seen or heard about an ATA device with a zero size, so I think its a bit academic, but I'll keep it in mind.. -Søren