From owner-cvs-all Tue May 19 09:01:17 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA13784 for cvs-all-outgoing; Tue, 19 May 1998 09:01:17 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from roma.coe.ufrj.br (jonny@roma.coe.ufrj.br [146.164.53.65]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA13633; Tue, 19 May 1998 09:00:43 -0700 (PDT) (envelope-from jonny@jonny.eng.br) Received: (from jonny@localhost) by roma.coe.ufrj.br (8.8.8/8.8.8) id MAA16087; Tue, 19 May 1998 12:58:47 -0300 (EST) (envelope-from jonny) From: Joao Carlos Mendes Luis Message-Id: <199805191558.MAA16087@roma.coe.ufrj.br> Subject: Re: cvs commit: src/sys/pci brooktree848.c In-Reply-To: <199805190655.XAA00354@rah.star-gate.com> from Amancio Hasty at "May 18, 98 11:55:45 pm" To: hasty@rah.star-gate.com (Amancio Hasty) Date: Tue, 19 May 1998 12:58:47 -0300 (EST) Cc: luigi@labinfo.iet.unipi.it, ahasty@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, roger@cs.strath.ac.uk, multimedia@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL40 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk #define quoting(Amancio Hasty) // When either you or Roger can verify the new sysctl hw.bt848.format, // I will commit the fix. // // hw.bt848.format = 0 | 1 // // 0 Denotes PAL // 1 Denotes NTSC Shouldn't there be also the sub-formats, like NTSM/M, NTSC/J, PAL/I, PAL/M, etc ? I'm thinking of the BT848SFMT ioctl, and not the old compatibility METEORSFMT one. BTW: Somebody has messed up PAL/M again. PAL/M is NTSC-like, not PAL-like, despite it's name. It's indeed a 60/525 system with support for Phase Alternated Lines (PAL). So the ioctl BT848SFMT has to be changed, and, please, add a comment to avoid future changes. Curiously, the struct format_params seems unchanged. Unfortunatly, I don't have a bt848 anymore to test these. While I'm here, I'd like to note that sysctl is somewhat like SNMP, and SNMP variables have a unit name as this small extract from a snmpwalk shows. interfaces.ifTable.ifEntry.ifInOctets.1 = 204219604 interfaces.ifTable.ifEntry.ifInOctets.2 = 0 interfaces.ifTable.ifEntry.ifInOctets.3 = 0 interfaces.ifTable.ifEntry.ifInOctets.4 = 32787782 interfaces.ifTable.ifEntry.ifInOctets.5 = 0 Things that have the notion of units should reflect this in its sysctl, even if 99.999% of people only have one of those interfaces. Of course, this is just my very humble opinion. Jonny -- Joao Carlos Mendes Luis M.Sc. Student jonny@jonny.eng.br Universidade Federal do Rio de Janeiro To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message