From owner-svn-src-all@FreeBSD.ORG Fri Jul 12 20:27:18 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id BEA6074; Fri, 12 Jul 2013 20:27:18 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-lb0-x236.google.com (mail-lb0-x236.google.com [IPv6:2a00:1450:4010:c04::236]) by mx1.freebsd.org (Postfix) with ESMTP id 7A5F81D71; Fri, 12 Jul 2013 20:27:17 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id r11so7993230lbv.13 for ; Fri, 12 Jul 2013 13:27:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=8f4gDBddKqeWw+3cet36rBc1u/LgCKj2dRiWB8y04ZQ=; b=WkJSzphz2l39qiwYRj1urAUmyut/UlaOrj36dAhXyJ0hhd5RhfK0QFH23oIRqCGPAa J6QMR5nreuqSaNUzoi36CThihhqJRmmH2s53WR2wSZkgoxdiNud7PeNTw5mIWqo/fRRR uGmpRH5cIc7OooTo+2uDWW+QtytzjHkkwVj1N0RgR0ixiViWHpZtw9pXs5rafacL0CgW kwUAg0MfLcs8LQroITdFznpGB9gZ3DXNV+BY6eaCRZe5HcWZqRF2/WZtCB0FIqtPT9MU inTweWCzgZFm6ckI3FD4jcEoA0zNOmzGjUVI08Vq5bB53EiKiKF7mjDnYIclp+4fJccO Xyyg== X-Received: by 10.152.21.99 with SMTP id u3mr20607353lae.18.1373660835579; Fri, 12 Jul 2013 13:27:15 -0700 (PDT) Received: from localhost ([178.150.115.244]) by mx.google.com with ESMTPSA id et10sm14505281lbc.6.2013.07.12.13.27.13 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 12 Jul 2013 13:27:14 -0700 (PDT) Sender: Mikolaj Golub Date: Fri, 12 Jul 2013 23:27:12 +0300 From: Mikolaj Golub To: Craig Rodrigues Subject: Re: svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt Message-ID: <20130712202710.GB2757@gmail.com> References: <201307120803.r6C83ACp016523@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Adrian Chadd , src-committers@freebsd.org, Marko Zec X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jul 2013 20:27:18 -0000 On Fri, Jul 12, 2013 at 11:39:34AM -0700, Craig Rodrigues wrote: > I like your patch. It may be worth having one more Netgraph person review > it and give a sanity check, but > I think we should commit your patch ASAP. > I am new to VNET, but I am wondering if in your patch we can KASSERT if > node->vnet is NULL. That would make > things easier to debug. > > The part of my patch which which does CURVNET_SET is still necessary upon > attach in Bluetooth. > However, with your patch, we can get rid of the part of my patch which does > CURVNET_SET upon Bluetooth detach. Some time ago there was a long discussion about VIMAGE issue with hotplugabble network devices: http://lists.freebsd.org/pipermail/freebsd-hackers/2012-October/040784.html (I wander why Adrian did not mention it as he was deeply involved) Then Marko came up with a patch that mihght fix the issue in a more generic way: http://lists.freebsd.org/pipermail/freebsd-hackers/2012-November/041120.html Unfortunately it was not tested. I think it would be very interesting to try it with hotplugabble devices. (I don't have any so can't test). -- Mikolaj Golub