From owner-cvs-usrbin Sun May 14 23:29:37 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id XAA18590 for cvs-usrbin-outgoing; Sun, 14 May 1995 23:29:37 -0700 Received: from freud.hut.fi (freud.hut.fi [192.26.109.226]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id XAA18582 ; Sun, 14 May 1995 23:29:29 -0700 Received: (from vode@localhost) by freud.hut.fi (8.6.11/8.6.7) id JAA06651; Mon, 15 May 1995 09:28:56 +0300 Date: Mon, 15 May 1995 09:28:56 +0300 (EET DST) From: Kai Vorma To: Nate Williams cc: "Andrey A. Chernov" , CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c In-Reply-To: <199505150016.SAA24242@trout.sri.MT.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk On Sun, 14 May 1995, Nate Williams wrote: > Andrey A. Chernov writes: > > ache 95/05/14 17:03:33 > > > > Modified: usr.bin/rpcgen rpc_parse.c > > Log: > > End of listcan be not marked, fix it > > Submitted by: Kai Vorma > > I looked at this fix, and I'm not sure that the proposed 'fix' was > necessary. Did you look at the fix at determine if it was indeed needed? Without this fix the last plist->next link is uninitialized. rpcgen still works, because the way BSD malloc works (it cannot reuse freed memory so it asks more from the system and that memory is zeroed -> next-link happens to be NULL). I have replaced the system malloc with a better one and rpcgen dumps core without this patch. ..vode