From nobody Sat Oct 4 19:35:10 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cfG2l0x6Hz69ftp; Sat, 04 Oct 2025 19:35:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cfG2k5y0rz3qpv; Sat, 04 Oct 2025 19:35:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759606510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8PUOwFBj9ayjhbwtqDmgxsWcf9bfmBITQxArf7tTf4I=; b=TIMUQBkGInPIMoTI6w6zOXJVsSASmIMX9C37RdYTTlt4zAn3Z7xjwHI9nsgDdgy/zNv9B+ PT0zbh3LIXZ96OQlDDjZCEDHsEn24ZsdZmmf3pUJOnWeUhliBznvY9gBTdD1yk691nZxUn x79gK1hP6W/pb3pRe8ca+KTZY1IYvVsIyBOsLWnKE7Oks9OJFdwBtQjHr8ucO/RZSOZtMA Dp3pxeIe81wVHKjIKPFsV99Rn3fCzhXwDTRe5SqyQeEWzQUSrsBRHw9PExuC9BjNFyPUNq C5Th1veiUG9JjtznmfHWNDv4/BKeiIAJckbtdR/Gc6CiI/M262L2Qi3Zlan8Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759606510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8PUOwFBj9ayjhbwtqDmgxsWcf9bfmBITQxArf7tTf4I=; b=bA5z1UJaMwa8Itlw2Cdy+iikAkFfIhp9VZghhrwr9Z55b9BDVztt58xDBoxcydz/XLLly0 WL+/Iyu+hlKcyd1xHnXIENVMNeRHAcG0WbA7pxP79NwJxn4g4GYIZjXNzYiilwVi5i/fIP nRJFl+rkO1FS3kwMFYjsP+WbvkNEc8PbigMo8GtH3j7s2fXnIpQiSuwSRY4GIQVmbysw0c e/UBvneEiGLZeGvXuOkj2UvcCRoKxUXqKNugNr0s89mckpsPFY5qpktxA1gP/PKN8LJfns QFRoVFcHyRW3AFIyxs03AhbvvlLc1ZjH/R03cHlYWw5IMb18MCdI0sKGX57J/Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759606510; a=rsa-sha256; cv=none; b=HlCuDqQOemKc7G9pXqWCnw1sVBumGqnFb5wiSq5pOp6C+tYrblirhGTByX172Tlj+jriiJ dijzSCAToOB1ukLkjFiopH6PQ0gcj+CSNZQdlCSyMZg8l8wMmuHsN6oupp4+/EMXWLpOC+ gyfL2rIlJfR4TGm3oiNvgf4OSHFnsPtAckP6jp8teGMbMkox1IuYdhpYO/tD5JxxeyDLwq JSHgy4ZICV8Pu47yvLyeoLgJGeXENDYSFTkiwenzlkZf/eUWJ62PvLkw5KI4ZrgKI+usob fB5TIy+2QwRmDMnFqowPx26t1MkCSwUjV0COi5SUA9jhfFZpnL96rZI9eu0yzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cfG2k5Xx1zvh1; Sat, 04 Oct 2025 19:35:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 594JZATo079043; Sat, 4 Oct 2025 19:35:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 594JZARS079040; Sat, 4 Oct 2025 19:35:10 GMT (envelope-from git) Date: Sat, 4 Oct 2025 19:35:10 GMT Message-Id: <202510041935.594JZARS079040@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 8b6d7e8fe396 - stable/15 - pw: Print warnings when metadata updates fail List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 8b6d7e8fe3967db29527a32206349dc954e83a26 Auto-Submitted: auto-generated The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=8b6d7e8fe3967db29527a32206349dc954e83a26 commit 8b6d7e8fe3967db29527a32206349dc954e83a26 Author: Mark Johnston AuthorDate: 2025-09-18 22:38:33 +0000 Commit: Mark Johnston CommitDate: 2025-10-04 19:34:57 +0000 pw: Print warnings when metadata updates fail We do this in most places already, but not consistently. MFC after: 1 week Sponsored by: The FreeBSD Foundation Sponsored by: Klara, Inc. (cherry picked from commit daa63c9417a28ad08881ff03df828fd8180dad12) --- usr.sbin/pw/cpdir.c | 6 ++++-- usr.sbin/pw/pw_user.c | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/usr.sbin/pw/cpdir.c b/usr.sbin/pw/cpdir.c index 3dee8f7c43ac..63068cab000c 100644 --- a/usr.sbin/pw/cpdir.c +++ b/usr.sbin/pw/cpdir.c @@ -127,8 +127,10 @@ copymkdir(int rootfd, char const * dir, int skelfd, mode_t mode, uid_t uid, /* * Propagate special filesystem flags */ - fchown(destfd, uid, gid); - fchflags(destfd, st.st_flags); + if (fchown(destfd, uid, gid) != 0) + warn("chown(%s)", p); + if (fchflags(destfd, st.st_flags) != 0) + warn("chflags(%s)", p); close(destfd); } closedir(d); diff --git a/usr.sbin/pw/pw_user.c b/usr.sbin/pw/pw_user.c index 8a9a4342f5ef..9f5cfb0f4473 100644 --- a/usr.sbin/pw/pw_user.c +++ b/usr.sbin/pw/pw_user.c @@ -123,7 +123,8 @@ mkdir_home_parents(int dfd, const char *dir) if (fstatat(dfd, dirs, &st, 0) == -1) { if (mkdirat(dfd, dirs, _DEF_DIRMODE) == -1) err(EX_OSFILE, "'%s' (home parent) is not a directory", dirs); - fchownat(dfd, dirs, 0, 0, 0); + if (fchownat(dfd, dirs, 0, 0, 0) != 0) + warn("chown(%s)", dirs); } free(dirs);