From owner-cvs-all Sun Feb 17 20:33:34 2002 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 57DF837B404; Sun, 17 Feb 2002 20:33:30 -0800 (PST) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.5) with SMTP id g1I4XMD75703; Sun, 17 Feb 2002 23:33:23 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Sun, 17 Feb 2002 23:33:22 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sysv_sem.c In-Reply-To: <20020218143505.K4583-100000@gamplex.bde.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 18 Feb 2002, Bruce Evans wrote: > Er, style(9) doesn't have any requirements here AFAIK. The C standard > requires comments in /* ... */ and code (which may include comments) in > #if 0 ... #endif. (The previous version was neither comments nor code. > It was cdode for a language other than C mixed with C comments, all #if > 0'ed to limit its visibility. This only worked because the non-code > consisted of C tokens.) Hmm. I took that to be a comment, since it wasn't recognizable code. As such, I applied style(9)'s commenting rules to it. That discussion aside, I'm tempted to simply remove the comment since it's pretty redundant with respects to the declarations immediately above it (and was also wrong in several cases). Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message