From owner-freebsd-hackers Sun Nov 15 11:19:22 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA23544 for freebsd-hackers-outgoing; Sun, 15 Nov 1998 11:19:22 -0800 (PST) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from smtp02.primenet.com (smtp02.primenet.com [206.165.6.132]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA23493 for ; Sun, 15 Nov 1998 11:17:59 -0800 (PST) (envelope-from tlambert@usr07.primenet.com) Received: (from daemon@localhost) by smtp02.primenet.com (8.8.8/8.8.8) id MAA15078; Sun, 15 Nov 1998 12:17:30 -0700 (MST) Received: from usr07.primenet.com(206.165.6.207) via SMTP by smtp02.primenet.com, id smtpd015054; Sun Nov 15 12:17:29 1998 Received: (from tlambert@localhost) by usr07.primenet.com (8.8.5/8.8.5) id MAA27750; Sun, 15 Nov 1998 12:16:01 -0700 (MST) From: Terry Lambert Message-Id: <199811151916.MAA27750@usr07.primenet.com> Subject: Re: [Vinum] Stupid benchmark: newfsstone To: mike@smith.net.au (Mike Smith) Date: Sun, 15 Nov 1998 19:16:01 +0000 (GMT) Cc: tlambert@primenet.com, grog@lemis.com, mike@smith.net.au, ticso@cicely.de, peter.jeremy@auss2.alcatel.com.au, hackers@FreeBSD.ORG In-Reply-To: <199811150656.WAA10149@dingo.cdrom.com> from "Mike Smith" at Nov 14, 98 10:56:20 pm X-Mailer: ELM [version 2.4 PL25] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > > I'll tell you what: anybody who wants, go and look at the request > > > building code in /usr/src/lkm/vinum/request.c and rebuild it to > > > perform the "aggregation" optimizations that Bernd wants, and I'll > > > put it into the code. > > > > RAIDFrame was built as a research tool to allow people to test > > out just such theories, with the minimum amount of code, and no > > modification required to the framework in which the code runs. > > > > It's acutally the right tool for the job of testing these ideas > > out. > > ... it was also imported into NetBSD on the 12th. > > What's most irritating is that the vast majority of the diffs between > the original RAIDframe code and the version imported into the NetBSD > tree are noise - formatting, prototypes, etc. > > The actual meat is pretty trivial, but it makes me wonder who actually > reviewed the code, and what their criteria were... Ugh. I know that the patch set I made was just to make the thing compile; the author assured me that it would be rolled into the next release. I'm not sure whether my patches on freebsd.org are redundant yet, or not. Maybe the formatting changes came from a next release of the code? Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message