From owner-freebsd-net@FreeBSD.ORG  Wed Dec  8 21:11:25 2004
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2D28416A4CE
	for <net@freebsd.org>; Wed,  8 Dec 2004 21:11:25 +0000 (GMT)
Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 67C1C43D5A
	for <net@freebsd.org>; Wed,  8 Dec 2004 21:11:24 +0000 (GMT)
	(envelope-from ru@ip.net.ua)
Received: from localhost (rocky.ip.net.ua [82.193.96.2])
	by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iB8LBN2v097854;
	Wed, 8 Dec 2004 23:11:23 +0200 (EET)
	(envelope-from ru@ip.net.ua)
Received: from tigra.ip.net.ua ([82.193.96.10])
 by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP
 id 57275-18; Wed,  8 Dec 2004 23:11:22 +0200 (EET)
Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213])
	by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iB8LBMcG097851
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 8 Dec 2004 23:11:22 +0200 (EET)
	(envelope-from ru@ip.net.ua)
Received: (from ru@localhost)
	by heffalump.ip.net.ua (8.13.1/8.13.1) id iB8LBMV5000101;
	Wed, 8 Dec 2004 23:11:22 +0200 (EET)
	(envelope-from ru)
Date: Wed, 8 Dec 2004 23:11:22 +0200
From: Ruslan Ermilov <ru@freebsd.org>
To: Max Laier <max@love2party.net>
Message-ID: <20041208211121.GB61146@ip.net.ua>
References: <20041207145932.GA1336@ip.net.ua>
	<200412082107.05872.max@love2party.net>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ZfOjI3PrQbgiZnxM"
Content-Disposition: inline
In-Reply-To: <200412082107.05872.max@love2party.net>
User-Agent: Mutt/1.5.6i
X-Virus-Scanned: by amavisd-new at ip.net.ua
cc: net@freebsd.org
Subject: Re: Another bug with netmasked aliases (with fix)
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Dec 2004 21:11:25 -0000


--ZfOjI3PrQbgiZnxM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Max,

On Wed, Dec 08, 2004 at 09:06:58PM +0100, Max Laier wrote:
> Any reason you didn't include the following (also part
> of OpenBSD rev. 1.47)?:
>=20
I developed it independently of OpenBSD, and only later
found that OpenBSD also had it, so I missed this part.
It's indeed needed.

> |       /*
> |        * make sure to set rt->rt_ifa to the interface
> |        * address we are using, otherwise we will have trouble
> |        * with source address selection.
> |        */
> |       ifa =3D &ia->ia_ifa;
> |       if (ifa !=3D rt->rt_ifa) {
> |               IFAFREE(rt->rt_ifa);
> |               ifa->ifa_refcnt++;
> |               rt->rt_ifa =3D ifa;
> |       }
>=20
>=20
> Updated diff attached. Not sure if it makes any difference?
>=20
Of course it does.  Without it, "ping <alias>" comes from
the main address, where it should come from <alias>.

Reviewed.  Please commit.


Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer

--ZfOjI3PrQbgiZnxM
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)

iD8DBQFBt235qRfpzJluFF4RAm8QAKCPFKnIlVpJVwId9mRGj6iBYhLKoQCeIhPb
gNHjyU1iix/vGpbU8LoMPgc=
=KQw/
-----END PGP SIGNATURE-----

--ZfOjI3PrQbgiZnxM--