From nobody Sat Feb 21 15:23:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fJ9qK0kXjz6SnKt for ; Sat, 21 Feb 2026 15:23:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fJ9qJ5xxxz3hGZ for ; Sat, 21 Feb 2026 15:23:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771687388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AwFFxGlHH4E2YkZtwg8djZifAS9h1mZUPlhDIr9j+0I=; b=mMtHC/t878moV5c4TzNXdaLp771T0emh3E4mm+D8SFdijq4UCvhYUSps9167YI4Di31dwM z7a0pxZv4BVXmSIXQAT8TQj6El4690U13MX8+vUWKuSDrxn4U4T2e+sHwqkDFa818Skfnx JCG5iKEO8qQKBKRUN1eO/x4nqAiN8QijciYGyeaKWxYemsdrF9ULhHvY/VHkC8SuoJ6eal 0OOTB57gAHfKjADTM/jt8nVD50v+ddZ7f43HEdD+qO+pw/j+91ib437xl7oFmW4ym3z9GI uf7FpdL2PWCyfUKgwMZANU/cGSeTELkR1m0/HjRlzl56B1HGYqhEbsPoZeLfTg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771687388; a=rsa-sha256; cv=none; b=RMsJFpxOtBaizVyc43i7107WrKG1vzYMTqN8Tg100xIyPnnC8ot7Co1U55MaFWcD2TrAkX jV84Fme3YU1NbtJg7zNIATLNUbYunGs19t7MY3jbU8/e8uPfHxr7GITXxBsBkkQ7A+YQXi VoF6fbKVqretQ1297rbQ1CcjuCjDvBaaekptfIx11+nHcAIxG0bVH6iJYyVWDJw0YVrzXx ZRBU6q537L910c6zfSm0hSBGW408UatHEYTG/bJqVJ6mbgPirhiPVC4WEDwyaW7RLwWwOP 6CBNwngSogmrpWEprO7/QPJbl1jqLvuiBouZnUgR4VJQOrencRn0g54AJBBHlg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771687388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AwFFxGlHH4E2YkZtwg8djZifAS9h1mZUPlhDIr9j+0I=; b=Tld2aXGw52IAwau0VXvgf/24kiwnGIXwBgXtUnqniDNH99VqjzvPe/pnMrQ81rOn9Olde6 qBbzzBJ5xelC7TcDo76SNf3vIl9Ftme3wPWIGelX7Qj6Hg2/ejltC13ysiXhT7GTmtiu/t uSxqD9shPb8u1nY7Z79HXJd+JLwGaJlRztAAWrGI8FlY9VmVYdfBizP/pcNYqX2tdr/GSH g65YQLyP1Tr2zFvMrJ2aEFMa6113HI77Ho8rutII89L/1ave/EQDLtCc9B+ElEijwNhae4 sNTOcBuupRtP526R6it0Y8LyBYCOx3Rvj4lgJ6+a4aqE4bQgn+dcrVKfkC1pug== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fJ9qJ4kNKz1J0R for ; Sat, 21 Feb 2026 15:23:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24995 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 21 Feb 2026 15:23:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Toomas Soome Subject: git: f2186bbd63fc - main - loader.efi: free_tables() appears to free tss_pa twice. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tsoome X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f2186bbd63fc4185a42740dfee8c403e3d9b2ae9 Auto-Submitted: auto-generated Date: Sat, 21 Feb 2026 15:23:08 +0000 Message-Id: <6999cddc.24995.50f03168@gitrepo.freebsd.org> The branch main has been updated by tsoome: URL: https://cgit.FreeBSD.org/src/commit/?id=f2186bbd63fc4185a42740dfee8c403e3d9b2ae9 commit f2186bbd63fc4185a42740dfee8c403e3d9b2ae9 Author: Toomas Soome AuthorDate: 2026-02-21 15:20:54 +0000 Commit: Toomas Soome CommitDate: 2026-02-21 15:20:54 +0000 loader.efi: free_tables() appears to free tss_pa twice. we check and reset loader_gdt_pa, but use FreePages(tss_pa). Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D55179 --- stand/efi/loader/arch/amd64/trap.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/stand/efi/loader/arch/amd64/trap.c b/stand/efi/loader/arch/amd64/trap.c index 97e78ecccf22..ffd84db40a3a 100644 --- a/stand/efi/loader/arch/amd64/trap.c +++ b/stand/efi/loader/arch/amd64/trap.c @@ -74,6 +74,7 @@ static uint32_t tss_fw_seg; /* Fw TSS segment */ static uint32_t loader_tss; /* Loader TSS segment */ static struct region_descriptor fw_gdt; /* Descriptor of pristine GDT */ static EFI_PHYSICAL_ADDRESS loader_gdt_pa; /* Address of loader shadow GDT */ +static UINTN loader_gdt_pa_size; struct frame { struct frame *fr_savfp; @@ -194,7 +195,7 @@ free_tables(void) tss_pa = 0; } if (loader_gdt_pa != 0) { - BS->FreePages(tss_pa, 2); + BS->FreePages(loader_gdt_pa, loader_gdt_pa_size); loader_gdt_pa = 0; } ist = 0; @@ -294,13 +295,13 @@ efi_redirect_exceptions(void) loader_gdt.rd_limit = roundup2(fw_gdt.rd_limit + sizeof(struct system_segment_descriptor), sizeof(struct system_segment_descriptor)) - 1; + loader_gdt_pa_size = + EFI_SIZE_TO_PAGES(loader_gdt.rd_limit); i = (loader_gdt.rd_limit + 1 - sizeof(struct system_segment_descriptor)) / sizeof(struct system_segment_descriptor) * 2; status = BS->AllocatePages(AllocateAnyPages, - EfiLoaderData, - EFI_SIZE_TO_PAGES(loader_gdt.rd_limit), - &loader_gdt_pa); + EfiLoaderData, loader_gdt_pa_size, &loader_gdt_pa); if (EFI_ERROR(status)) { printf("efi_setup_tss: AllocatePages gdt error " "%lu\n", DECODE_ERROR(status));