From owner-freebsd-stable@freebsd.org Sat Jan 16 13:00:01 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AA3C6A84AEA for ; Sat, 16 Jan 2016 13:00:01 +0000 (UTC) (envelope-from philippe.michel7@sfr.fr) Received: from smtp24.services.sfr.fr (smtp24.services.sfr.fr [93.17.128.83]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47EFF118B for ; Sat, 16 Jan 2016 13:00:00 +0000 (UTC) (envelope-from philippe.michel7@sfr.fr) Received: from filter.sfr.fr (localhost [86.69.158.230]) by msfrf2419.sfr.fr (SMTP Server) with ESMTP id A382C70000BE for ; Sat, 16 Jan 2016 13:51:28 +0100 (CET) Authentication-Results: sfrmc.priv.atos.fr; dkim=none (no signature); dkim-adsp=none (no policy) header.from=philippe.michel7@sfr.fr Received: from 230.158.69.86.rev.sfr.net (230.158.69.86.rev.sfr.net [86.69.158.230]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by msfrf2419.sfr.fr (SMTP Server) with ESMTP id 482BA700008B for ; Sat, 16 Jan 2016 13:51:28 +0100 (CET) X-SFR-UUID: 20160116125128295.482BA700008B@msfrf2419.sfr.fr Date: Sat, 16 Jan 2016 13:51:26 +0100 (CET) From: Philippe Michel To: freebsd-stable@freebsd.org Subject: Re: make installworld creates empty dirs which are deleted by make delete-old In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (BSF 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jan 2016 13:00:01 -0000 On Sat, 16 Jan 2016, freebsd-stable-request@freebsd.org wrote: > I updated the server 3 times in one week (to 10.2-p8, -p9, -p10). > Those directories were deleted by delete-old > > # make -DBATCH_DELETE_OLD_FILES delete-old > >>> Removing old files (only deletes safe to delete libs) > >>> Old files removed > >>> Removing old directories > /usr/share/doc/atf > /usr/share/atf > /usr/include/atf-c++ > /usr/include/atf-c > >>> Old directories removed > To remove old libraries run 'make delete-old-libs'. > > By after next installworld, they are back. You build world WITHOUT_TESTS=true, don't you ? There are many of these flags that are somehow missed when creating directories at install. FWIW, with more WITHOUT flags set to true, my own list of directories created again and again is : >>> Removing old directories /usr/share/snmp/mibs /usr/share/snmp/defs /usr/share/snmp /usr/share/examples/pf /usr/share/examples/ipfilter /usr/share/examples/hast /usr/share/examples/bhyve /usr/share/doc/smm/07.lpd /usr/share/doc/atm /usr/share/doc/atf /usr/share/atf /usr/libexec/lpr/ru /usr/libexec/lpr /usr/include/netnatm/sig /usr/include/netnatm/saal /usr/include/netnatm/msg /usr/include/netnatm/api /usr/include/netgraph/bluetooth/include /usr/include/netgraph/bluetooth /usr/include/krb5 /usr/include/kadm5 /usr/include/gpib /usr/include/dev/ieee488 /usr/include/bsnmp /usr/include/atf-c++ /usr/include/atf-c /etc/bluetooth /etc/autofs >>> Old directories removed I think some similar cases were fixed a few months ago by NGie Cooper but it was apparently those he stumbled on by himself or some specific bug reports rather than the start of a more exhaustive sweep. I suppose opening a PR could have helped but I procrastinated :-(.