From owner-freebsd-commit Sat Dec 9 22:50:25 1995 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id WAA04594 for freebsd-commit-outgoing; Sat, 9 Dec 1995 22:50:25 -0800 (PST) Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id WAA04431 for cvs-all-outgoing; Sat, 9 Dec 1995 22:47:41 -0800 (PST) Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id WAA04420 for cvs-sys-outgoing; Sat, 9 Dec 1995 22:47:39 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id WAA04408 Sat, 9 Dec 1995 22:47:08 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id RAA14312; Sun, 10 Dec 1995 17:44:11 +1100 Date: Sun, 10 Dec 1995 17:44:11 +1100 From: Bruce Evans Message-Id: <199512100644.RAA14312@godzilla.zeta.org.au> To: bde@freefall.freebsd.org, peter@jhome.DIALix.COM Subject: Re: cvs commit: src/sys/net if_tun.c Cc: CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Sender: owner-commit@FreeBSD.ORG Precedence: bulk >> Removed an `#ifdef __FreeBSD__'. Hundreds, if not thousands of other >> FreeBSD-specific things aren't ifdefed. >I think our source could stand a lot more cleanup in this way.. After >all, our sources are for FreeBSD, not GenericBSD or PortableBSD... >Especially so, since we've not been consistant. I think the only real >place where this kind of thing needs to stay is where we've taken 3rd >party device drivers into our source that we dont maintain ourselves, and >have cross-machine and version portability built in (if_cx and cx.c for >example). We do sort of maintain the 3rd party drivers. It's hard to maintain them without breaking the portablity cruft. E.g., cx.c is currently broken for all versions of FreeBSD >= 2.0 and < current because a bogus FreeBSD >= 2 ifdef is used to decide if the devswitch functions are static. Bruce