Date: Sun, 10 Dec 1995 17:44:11 +1100 From: Bruce Evans <bde@zeta.org.au> To: bde@freefall.freebsd.org, peter@jhome.DIALix.COM Cc: CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/net if_tun.c Message-ID: <199512100644.RAA14312@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>> Removed an `#ifdef __FreeBSD__'. Hundreds, if not thousands of other >> FreeBSD-specific things aren't ifdefed. >I think our source could stand a lot more cleanup in this way.. After >all, our sources are for FreeBSD, not GenericBSD or PortableBSD... >Especially so, since we've not been consistant. I think the only real >place where this kind of thing needs to stay is where we've taken 3rd >party device drivers into our source that we dont maintain ourselves, and >have cross-machine and version portability built in (if_cx and cx.c for >example). We do sort of maintain the 3rd party drivers. It's hard to maintain them without breaking the portablity cruft. E.g., cx.c is currently broken for all versions of FreeBSD >= 2.0 and < current because a bogus FreeBSD >= 2 ifdef is used to decide if the devswitch functions are static. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199512100644.RAA14312>