Date: Fri, 20 Mar 2015 14:54:01 -0600 From: Adam Weinberger <adamw@adamw.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r381760 - in head/x11-fonts/sourcesanspro-ttf: . files Message-ID: <E46BF368-5492-482B-BF71-8F4987460DCB@adamw.org> In-Reply-To: <550C85B0.5050902@FreeBSD.org> References: <201503201823.t2KIN32I080448@svn.freebsd.org> <550C6655.5010802@FreeBSD.org> <20150320183524.GD87678@ivaldir.etoilebsd.net> <9BE33FCA-5C2F-4FEA-9B3A-5D9DB6632635@adamw.org> <550C6B34.8020401@FreeBSD.org> <550C85B0.5050902@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 20 Mar, 2015, at 14:40, Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>=20
> On 3/20/2015 1:47 PM, Bryan Drewery wrote:
>> On 3/20/2015 1:43 PM, Adam Weinberger wrote:
>>>=20
>>>> On 20 Mar, 2015, at 12:35, Baptiste Daroussin <bapt@FreeBSD.org> =
wrote:
>>>>=20
>>>> On Fri, Mar 20, 2015 at 01:26:29PM -0500, Bryan Drewery wrote:
>>>>> On 3/20/2015 1:23 PM, Baptiste Daroussin wrote:
>>>>>> +WRKSRC=3D =
${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME:S,/,-,}
>>>>>=20
>>>>> I think we should put this globally in this 1 line:
>>>>>=20
>>>>> bsd.port.mk
>>>>> 1561 . if defined(GH_TAGNAME)
>>>>> 1562 WRKSRC?=3D ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME}
>>>>>=20
>>>>>=20
>>>>> After https://reviews.freebsd.org/D2103 is resolved I will fix =
that.
>>>>=20
>>>> Almost in this case upstream decided to put a / in the TAGNAME =
which is ... well
>>>> ... :)
>>>=20
>>> It would be so unbelievably nice if we had a way to just specify the =
destination filename, using fetch -o. All the bizarre names that files =
are published as, the unversioned tarballs, the documentation files =
labelled Documentation.pdf, and the fallout from changes like this.... =
we could make our lives so much easier with a DISTFILE_DEST variable.
>>>=20
>>> # Adam
>>>=20
>>>=20
>>=20
>> For USE_GITHUB that is exactly what DISTNAME is. You can name it
>> whatever you want.
>>=20
>> As for your other examples I agree. I'll look into that!
>>=20
>=20
> Thinking about it a bit more I don't have time to implement this today
> or soon.
>=20
> DISTFILES would need a syntax to specify an output filename. The
> do-fetch and do-checksum targets in bsd.port.mk would need a lot of
> rework. They are very risky to touch and hard to maintain as is.
>=20
> Ideas for a DISTFILES format?
I think what you're talking about is essentially overloading the =
DISTFILES variable to be usable as a template, correct? Wouldn't:
.if defined(DISTFILE_DEST)
FETCH_ARGS +=3D -o ${DISTFILE_DEST}
DISTFILES +=3D ${DISTFILE_DEST}
.endif
be simpler? I'll be honest, I haven't looked into the do-fetch and =
do-checksum targets yet, but specifying the destination filename =
manually means that you already know exactly what needs to be added to =
DISTFILES.
# Adam
--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E46BF368-5492-482B-BF71-8F4987460DCB>