From nobody Sun Apr 12 13:44:20 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ftsGF2lzxz6ZLs1 for ; Sun, 12 Apr 2026 13:44:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ftsGD6SGgz3kyY for ; Sun, 12 Apr 2026 13:44:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776001460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=odCDC46RP51IlO4RYefq3am/UPDx2z3iwUfQSbE2SuU=; b=jvbLE8nIXTjRMUYmWx34s95+qvFRY5eTCmk13r6XDeE55s3ov23KNPpSxrABJ/ecUuJrUi lFMWOhovHZO3fL7//vEe1GQ1n9vAjIGK/SfkmQKcPdi9j4jkd1mTPezfwRvXMtOaKVNpLC iQAzYiC+DdUjncy5ZmiHCMl+DTXNp3G5A2IioMUVUGFkn6chkz1G5653KekhQIv8ku3CcX VpAARfeta+++G/0SEw287k6K8pKbynNtgk4TqIIqFzrqTqz1ltHCHXB2jLq4yNdjlAyNev TNtNs8yj8nCHmMPjSNd8oBkWVMEvL23GEbPASGH9770z30kvzPO8BBjpbgbxVA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776001461; a=rsa-sha256; cv=none; b=Pwz+1VqcRU9rOjW9t2aBFhB/QxU9TyqJNWyEp0Fyf62bkTPk6g8EuzNiYwoZ3TgWVwlmRu 7weyF2H3cjsqL53LYy0hZjiMV+Boup1ovXbrdRQi8XqJT+EH42FsNOZ9c1GJ1l+6BVAidA MWGY31u9J7kuXs59f09AT33mDLeLkXZ7w9JrkEdJHCai1grIrm2YltmoQH62jCBOhFF0xf aIhmxCjQbSDd1Z2k/tttF6Prx5EEphr5gATTw9jQyLZPoux1gcH0OpT1aKFDwAxqIoxnZF VapxrYYwSog9FM43N7OJYB6x155gwsbhS6jmw1OxE69Y2UTo3HXs7buCroOy5A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776001460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=odCDC46RP51IlO4RYefq3am/UPDx2z3iwUfQSbE2SuU=; b=coDqg6OpeKzn7wBIVBB4dNz8S8tjeoPFuqpQ8eR9hL9TT4LcisROmDhzBPVojtYS77hTkb ei9VtqdO73XybT2iodME3tO400APo8NzT1rFU+JLWZm+DiJhrdT2Sd+6oqpLSQx0H2Dk1p F2f4NHeRDe6p7XkhUhTpaR6ez0rd86vSlo0uJopSqM/Fk6D2I6DYt9b6qAlSx6mcYL4e3o lU9aln2CPtcphI/Mse4i2lK8BR7Zo2rAPsmJbaKd253e9J6BkbMI43SJJ7zERY+ank17Uc Nb0HjfpMiF8kns2XgXssDLCjp0TQwQWNjomggDQ+sAPixz+JZ2y/IQwcszAtew== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4ftsGD62nLz4TQ for ; Sun, 12 Apr 2026 13:44:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 423cd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 12 Apr 2026 13:44:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Abdelkader Boudih From: Kyle Evans Subject: git: 874d779aa7dd - stable/14 - firmware: Fix inverted FIRMWARE_GET_NOWARN logic List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 874d779aa7ddc8216b06e58ff955adf2a54a17d5 Auto-Submitted: auto-generated Date: Sun, 12 Apr 2026 13:44:20 +0000 Message-Id: <69dba1b4.423cd.77de3348@gitrepo.freebsd.org> The branch stable/14 has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=874d779aa7ddc8216b06e58ff955adf2a54a17d5 commit 874d779aa7ddc8216b06e58ff955adf2a54a17d5 Author: Abdelkader Boudih AuthorDate: 2026-01-30 00:02:47 +0000 Commit: Kyle Evans CommitDate: 2026-04-12 13:43:42 +0000 firmware: Fix inverted FIRMWARE_GET_NOWARN logic The try_binary_file() function has inverted logic for the FIRMWARE_GET_NOWARN flag. When the flag is set (meaning "don't warn"), the code sets warn=true and makes noise anyway. Invert the assignment to warn to correctly suppress warnings when FIRMWARE_GET_NOWARN is set. Reviewed by: kevans (cherry picked from commit fdcd67be8274d237ae2c87d6475d9d34b440b8d8) --- sys/kern/subr_firmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/subr_firmware.c b/sys/kern/subr_firmware.c index e8f9493decc0..a315209a04cf 100644 --- a/sys/kern/subr_firmware.c +++ b/sys/kern/subr_firmware.c @@ -282,7 +282,7 @@ try_binary_file(const char *imagename, uint32_t flags) int oflags; size_t resid; int error; - bool warn = flags & FIRMWARE_GET_NOWARN; + bool warn = (flags & FIRMWARE_GET_NOWARN) == 0; /* * XXX TODO: Loop over some path instead of a single element path.