From owner-freebsd-net@FreeBSD.ORG Sat Jan 23 13:42:58 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED6551065693 for ; Sat, 23 Jan 2010 13:42:57 +0000 (UTC) (envelope-from shteryana@gmail.com) Received: from mail-ew0-f211.google.com (mail-ew0-f211.google.com [209.85.219.211]) by mx1.freebsd.org (Postfix) with ESMTP id 59F6D8FC1B for ; Sat, 23 Jan 2010 13:42:56 +0000 (UTC) Received: by ewy3 with SMTP id 3so741023ewy.13 for ; Sat, 23 Jan 2010 05:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:reply-to:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; bh=2m8KHuG1Pvbk18pDG1hkT47rRjfU2lcDTMds1BBKiOA=; b=SEnwa3iGwIVWiHaxw8MGRtwnflXXilS3cJDPdHAYdZP47ZgzgsWyv+Mj7jBus1n2Pc XOBQbUcSYCjBfDIeM7va9vh9mC5Wwc9m7rIPTrh60nVC39wCU3emUjmj2q6j0jplwGKi PvFte9UbEb3JvvO3usXKuQ7HLJLLyColBqW1k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:reply-to:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=UGVpggOsEwf5z0Dvj+vwt/mk2nUdjoCf0Kf3RTrQNDhuBMJKf2gj+l+S7lfMDqQHEo 5OFx5ooGxWfLrkh5oGGQVv6QkF5y8SCycb6Qr8jM9yDjlr5iGa9Q61wODwPmDB+aBRH1 KfTw+sOSYQOx8qd4UGX4ETNEt7ZMtrawPkgMc= MIME-Version: 1.0 Sender: shteryana@gmail.com Received: by 10.213.46.67 with SMTP id i3mr3133136ebf.87.1264254175905; Sat, 23 Jan 2010 05:42:55 -0800 (PST) In-Reply-To: <201001221959.o0MJxnIs016854@freefall.freebsd.org> References: <201001221959.o0MJxnIs016854@freefall.freebsd.org> Date: Sat, 23 Jan 2010 15:42:55 +0200 X-Google-Sender-Auth: 290f4f78a36b166b Message-ID: <61b573981001230542l59a9ab6y26514a213bfbdb67@mail.gmail.com> From: Shteryana Shopova To: yongari@freebsd.org Content-Type: text/plain; charset=UTF-8 Cc: freebsd-net@freebsd.org Subject: Re: i386/142974: [patch][net][if_re] Teach the if_re driver to properly recognize hardware revisions with non-zero MAC rev. bits X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: syrinx@FreeBSD.org List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jan 2010 13:42:58 -0000 Hi, On Fri, Jan 22, 2010 at 9:59 PM, wrote: > Synopsis: [patch][net][if_re] Teach the if_re driver to properly recognize hardware revisions with non-zero MAC rev. bits > > State-Changed-From-To: open->feedback > State-Changed-By: yongari > State-Changed-When: Fri Jan 22 19:57:19 UTC 2010 > State-Changed-Why: > It looks like you have second generation RTL8168C PCIe controller. If I understand correctly the RTL8168C PCIe is a Gigabit Ethernet controller and mine's definately a Fast Ethernet > I guess hwrev variable would have value 0x34c00000 and I don't see > reason why it can't match an entry in re_hwrevs table which already > has that entry. Well, actually there's no 0x34C00000 in the Known revision codes, there's a 0x3C400000, but that's different, that's why the chip doesn't match any of the known HW ids. I really think the driver's biting three bits more than it can chew here > Would you show me the output of "CSR_READ_4(sc, RL_TXCFG)"? 0x37c00000 This is dmesg with the SVN driver - Jan 23 11:55:31 kernel: re0: port 0xec00-0xecff mem 0xfebff000-0xfebfffff,0xfdff0000-0xfdffffff irq 18 at device 0.0 on pci3 Jan 23 11:55:31 kernel: re0: Using 1 MSI messages Jan 23 11:55:31 kernel: re0: Chip rev. 0x34800000 Jan 23 11:55:31 kernel: re0: MAC rev. 0x00400000 Jan 23 11:55:31 kernel: re0: Unknown H/W revision: 0x34c00000 Jan 23 11:55:31 kernel: device_attach: re0 attach returned 6 dmesg after patch - Jan 23 12:58:04 kernel: re0: port 0xec00-0xecff mem 0xfebff000-0xfebfffff,0xfdff0000-0xfdffffff irq 18 at device 0.0 on pci3 Jan 23 12:58:04 kernel: re0: Using 1 MSI messages Jan 23 12:58:04 kernel: re0: HWREV - 0x37c00000 Jan 23 12:58:04 kernel: re0: Chip rev. 0x34800000 Jan 23 12:58:04 kernel: re0: MAC rev. 0x00400000 Jan 23 12:58:04 kernel: miibus0: on re0 Jan 23 12:58:04 kernel: re0: Ethernet address: 90:fb:a6:29:80:cd Jan 23 12:58:04 kernel: re0: [FILTER] Jan 23 13:00:31 kernel: re0: link state changed to UP Jan 23 13:00:40 dhclient: New Hostname (re0): Jan 23 13:00:40 dhclient: New IP Address (re0): 192.168.1.103 Jan 23 13:00:40 dhclient: New Subnet Mask (re0): 255.255.255.0 Jan 23 13:00:40 dhclient: New Broadcast Address (re0): 255.255.255.255 Jan 23 13:00:40 dhclient: New Routers (re0): 192.168.1.1 Just as a sidenote if it would help to understand the problem easier, while debugging the issue I used as a reference the DragonflyBSD driver - and more specifically this commit - http://www.mail-archive.com/commits@crater.dragonflybsd.org/msg09347.html > > > Responsible-Changed-From-To: freebsd-net->yongari > Responsible-Changed-By: yongari > Responsible-Changed-When: Fri Jan 22 19:57:19 UTC 2010 > Responsible-Changed-Why: > Grab. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=142974 >