From owner-freebsd-net@FreeBSD.ORG Thu Feb 26 14:50:59 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 90FDECB; Thu, 26 Feb 2015 14:50:59 +0000 (UTC) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D4E7FA4; Thu, 26 Feb 2015 14:50:58 +0000 (UTC) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 071C51FE022; Thu, 26 Feb 2015 15:50:49 +0100 (CET) Message-ID: <54EF32F9.1020009@selasky.org> Date: Thu, 26 Feb 2015 15:51:37 +0100 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: mike@karels.net Subject: Re: Adding new media types to if_media.h References: <201502261421.t1QELflw056051@mail.karels.net> <54EF2F2A.8060304@selasky.org> In-Reply-To: <54EF2F2A.8060304@selasky.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: "freebsd-net@freebsd.org" , Eric Joyner , Jack Vogel , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2015 14:50:59 -0000 On 02/26/15 15:35, Hans Petter Selasky wrote: > On 02/26/15 15:21, Mike Karels wrote: >>> I'm doing some work for Mellanox and we need some 100GBase types for >>> coming hardware products too. >> >>> I think we are not using the 32-bits of "ifm_media" well enough. >> >>> Has it been discussed to add more bits to "IFM_NMASK" and have more >>> ethernet types like IFM_ETHER_0, IFM_ETHER_1, IFM_ETHER_2, >>> IFM_ETHER_3 .... >> >>> Currently 5 IFM types are defined. If 2 more bits can be added to >>> IFM_NMASK we have 5 bits total giving us 2**5 = 32 IFM types. Then it >>> should be possible to define "(32 - 5) * 32 = 864" more ethernet types, >>> which I think should be enough for now - or we add even one more bit to >>> IFM_NMASK ? >> >> Did you have specific bits in mind? I'm fairly sure they are all >> assigned >> to something now. The adjacent bits are used for the subtype/variant and >> options. Most of the options are used, maybe not all. >> >> I haven't checked whether the "instance" field is still used, though. It >> was for MII PHY numbers, I believe. >> >> If we had more bits, it seems better to put them directly into the >> subtype >> field rather than the type field. >> >> Mike >> > > Hi, > > There are 6 token ring bits, which I presume are available when token > ring is not selected. > > #define IFM_TOK_ETR 0x00000200 /* Early token release */ > #define IFM_TOK_SRCRT 0x00000400 /* Enable source routing > features */ > #define IFM_TOK_ALLR 0x00000800 /* All routes / Single route > bcast */ > #define IFM_TOK_DTR 0x00002000 /* Dedicated token ring */ > #define IFM_TOK_CLASSIC 0x00004000 /* Classic token ring */ > #define IFM_TOK_AUTO 0x00008000 /* Automatic Dedicate/Classic > token ring */ > > Maybe these can be used for other purposes when the type is equal to > ethernet? > > --HPS > Hi Mike, My proposal is, convert: > #define IFM_TOK_DTR 0x00002000 /* Dedicated token ring */ > #define IFM_TOK_CLASSIC 0x00004000 /* Classic token ring */ > #define IFM_TOK_AUTO 0x00008000 /* Automatic Dedicate/Classic Into different network types: #define IFM_TOKEN_NONE #define IFM_TOKEN_DTR #define IFM_TOKEN_CLASSIC #define IFM_TOKEN_AUTO and extend the IFM_NMASK like this: #define IFM_NMASK 0x0000e0e0 /* Network type */ --HPS