From nobody Sun Sep 24 21:46:51 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rv02g2rYmz4tX11; Sun, 24 Sep 2023 21:46:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rv02g1wJfz4ZJP; Sun, 24 Sep 2023 21:46:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695592011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=R1xn26coI1oiYtCXQZyzC9mqE4FY5Liz4DRHTqg6Riw=; b=lRkPP3htMtxj+Cn+GTKy/fBmRpijPFj9KfUegeXH9mCyn1EQkfX6YOLe/OH/JMjOMk8BlQ V/3eCNsymeU3J8K8yacw4I6rDAyLg3WnveVDPNxWHenlkr22wykpHOQImYT1IiUn8tNnUX ylrMRlbXPvh8Yo1/tHhH7rVja2JgrSHjY0C0xtkmWIP8i3F4+sQfXfBt08hc2TzFMRArMW 8iby0e6Zfod9raHrdSdXpp8RlB6rRdjvMovEypIlERIGx9AsMZ0vF8cZws57JSTGoi9whj 1+L5RvEbGGGgJ+1TXfhUtXNdortLbBCKeL0G6qO8YMdM4BYs3euq7HPKZw2O8Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695592011; a=rsa-sha256; cv=none; b=Z8/rGEEimfYVuhWoc7e0K8avXhv9hUp3TnTifmnbhgfdlkb+Nbthpct5BXpq1GagWpJvmw 99WS3FZfgI/dxmmTPXJOMswJd5qG4UqKr17Udhz/0IZOemSpMR7nYo3lZY1T27Qc+z3Jb1 wnXU6Gd3TfaprGMgpR06oNqaLoOMAUFm/KoiD84Z2i5z0XO5dBpliLW5dXF83MlyRsrfcs ZBC/7QQwy7CnRXB0A5TzVXg/gkjdgeUa/W6BhZ30JLbLTWcZxwXc/LJpDMvBYEtWgQCuID rHsGxCrwxfPcWHlAp8/51nXyCtO5zNzDlbMv2rY7jl2O9dFLnQwvgTTbhsr+Ww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695592011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=R1xn26coI1oiYtCXQZyzC9mqE4FY5Liz4DRHTqg6Riw=; b=GDPQxSKTjuRewAbSkFfyMdZJYPFWGQqoGvK0zjQJ8rj1wCoQfFvQbpu6l7q63caqKov5E4 AzCuzOjafIJkZENN+YnbsCu3UXdtVcpW+l7QA4vEaYiOu/EG3c9QuLdg2Bd/IyOdzWFsAK ndoQfOyTqJBnO1uf/FCm0m4NNw1LShthNfSsA7GmzXdUbQmNWHu3xEnzjlh9C14mKrYTJw BXRFb7zZ9rIRIfsL3iSswkM/uo39OUIzL6xDdfJLwr8H16LZEBkz59uEMw/dfxt5+Lwj67 6tZCmFDDMgu9xHB1cnkXidiEGw2lCSTG84YAwRR5hfTmS+ad0VNAQcymYBhogg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rv02g0yM7z13j0; Sun, 24 Sep 2023 21:46:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38OLkpxM030521; Sun, 24 Sep 2023 21:46:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38OLkpBI030518; Sun, 24 Sep 2023 21:46:51 GMT (envelope-from git) Date: Sun, 24 Sep 2023 21:46:51 GMT Message-Id: <202309242146.38OLkpBI030518@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: 3e8f649ec351 - releng/14.0 - vfs: don't kick vnlru if it is already running List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.0 X-Git-Reftype: branch X-Git-Commit: 3e8f649ec3516a5506bbd3fd95051448e3b1b6d5 Auto-Submitted: auto-generated The branch releng/14.0 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=3e8f649ec3516a5506bbd3fd95051448e3b1b6d5 commit 3e8f649ec3516a5506bbd3fd95051448e3b1b6d5 Author: Mateusz Guzik AuthorDate: 2023-09-14 16:27:47 +0000 Commit: Mateusz Guzik CommitDate: 2023-09-24 21:45:41 +0000 vfs: don't kick vnlru if it is already running Further shaves some lock trips. Approved by: re (gjb) (cherry picked from commit 76f1153790b6d2e1a4f0389c3ac24e41d08f9ba6) (cherry picked from commit 2ea531b264df97bfea7d74c7f9414b2d3c5d4277) --- sys/kern/vfs_subr.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 80ec15f78028..4c9cb6200f10 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -1557,9 +1557,11 @@ vnlru_kick_locked(void) } static void -vnlru_kick(void) +vnlru_kick_cond(void) { + if (vnlruproc_sig) + return; mtx_lock(&vnode_list_mtx); vnlru_kick_locked(); mtx_unlock(&vnode_list_mtx); @@ -1812,7 +1814,7 @@ alloc: mtx_assert(&vnode_list_mtx, MA_NOTOWNED); rnumvnodes = atomic_fetchadd_long(&numvnodes, 1) + 1; if (vnlru_under(rnumvnodes, vlowat)) - vnlru_kick(); + vnlru_kick_cond(); return (uma_zalloc_smr(vnode_zone, M_WAITOK)); }