From owner-dev-commits-src-all@freebsd.org Fri Feb 26 22:03:31 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 492D3550AB0; Fri, 26 Feb 2021 22:03:31 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DnNvk5H2gz3DN2; Fri, 26 Feb 2021 22:03:30 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1614377008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5U12U8nzFxuYascZBGCfUWusxowOinHCTkGa8SrO/kw=; b=f4+OAdGgLdwVe60AxwnWX7QYfLhy4cApIlxuSuKtN9KYG22Oy1oxFtW4vBVf2KGF46Jvoy QVDvhDBZCpEsRXfwSOmws2YDJ+aXlUp7C10TQd88s96XgyciJgdsRXptzu1IkliDxGvQkR lKgOxPJ5asYHduBTKeOvA+WOb9m5pOY= Received: from amy (lfbn-idf2-1-644-4.w86-247.abo.wanadoo.fr [86.247.100.4]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 8ae885c9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 26 Feb 2021 22:03:28 +0000 (UTC) Date: Fri, 26 Feb 2021 23:03:27 +0100 From: Emmanuel Vadot To: Enji Cooper Cc: Baptiste Daroussin , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 2a50a9de8340 - main - terminfo: add terminfo database Message-Id: <20210226230327.2741e72fe3aef2918cc210d6@bidouilliste.com> In-Reply-To: References: <202102251327.11PDR4eC083842@gitrepo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DnNvk5H2gz3DN2 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 22:03:31 -0000 On Fri, 26 Feb 2021 13:41:31 -0800 Enji Cooper wrote: > > > On Feb 25, 2021, at 5:27 AM, Baptiste Daroussin wrote: > > > > The branch main has been updated by bapt: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=2a50a9de8340f08bd876e9e5993332ae14376f80 > > > > commit 2a50a9de8340f08bd876e9e5993332ae14376f80 > > Author: Baptiste Daroussin > > AuthorDate: 2021-02-23 16:17:32 +0000 > > Commit: Baptiste Daroussin > > CommitDate: 2021-02-25 13:25:32 +0000 > > > > terminfo: add terminfo database > > > > Tested by: manu, jbeich > > Hi Baptiste, > A question and a comment: > 1. Was this reviewed in Phabricator? > 2. The details on why the terminfo database is being added are a bit lean too to non-Unix users. Are you aware that we are developing a unix-like system ? > It would be nice if the motivation for the change was documented in the commit message. > Thanks! > -Enji -- Emmanuel Vadot