From owner-svn-ports-all@FreeBSD.ORG Thu Apr 2 11:15:04 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F2675C82; Thu, 2 Apr 2015 11:15:03 +0000 (UTC) Received: from mailrelay117.isp.belgacom.be (mailrelay117.isp.belgacom.be [195.238.20.144]) by mx1.freebsd.org (Postfix) with ESMTP id 15F7510C; Thu, 2 Apr 2015 11:15:02 +0000 (UTC) X-Belgacom-Dynamic: yes X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=i+EX5EtM4g4P/CrLY+sx2nOWHsqv9AlVwqc0uudqMuE= c=1 sm=2 a=6I5d2MoRAAAA:8 a=RmiSGkMkyz61ecMMxWEA:9 a=CjuIK1q_8ugA:10 a=K5Lq6WB3axV6WeLFO3kA:9 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BoBgDUIx1V/8q28VFcgwhSUAzFYoVzAoFFTQEBAQEBAX6EHwEFViMQCw4GBAklDyoeBhOIMwEIzRgBAQEBAQEBAQEBAQEBAQEBARuLKYRoEQeELQEEkliCB4YKgR6DNI93IoNwPDGCQwEBAQ Received: from 202.182-241-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.241.182.202]) by relay.skynet.be with ESMTP; 02 Apr 2015 13:13:52 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id t32BDoVM021049; Thu, 2 Apr 2015 13:13:50 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Thu, 2 Apr 2015 13:13:49 +0200 From: Tijl Coosemans To: Bryan Drewery Subject: Re: svn commit: r382977 - head/security/softhsm Message-ID: <20150402131349.72ea0182@kalimero.tijl.coosemans.org> In-Reply-To: <201504020012.t320Cj4P097842@svn.freebsd.org> References: <201504020012.t320Cj4P097842@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/jScke2AY4HXiKdtZwVNitAb" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2015 11:15:04 -0000 --MP_/jScke2AY4HXiKdtZwVNitAb Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On Thu, 2 Apr 2015 00:12:45 +0000 (UTC) Bryan Drewery wrote: > Author: bdrewery > Date: Thu Apr 2 00:12:44 2015 > New Revision: 382977 > URL: https://svnweb.freebsd.org/changeset/ports/382977 > > Log: > Thanks for breaking my domain > > Modified: > head/security/softhsm/Makefile > > Modified: head/security/softhsm/Makefile > ============================================================================== > --- head/security/softhsm/Makefile Thu Apr 2 00:12:13 2015 (r382976) > +++ head/security/softhsm/Makefile Thu Apr 2 00:12:44 2015 (r382977) > @@ -16,6 +16,9 @@ LIB_DEPENDS= libbotan-1.10.so:${PORTSDIR > libsqlite3.so:${PORTSDIR}/databases/sqlite3 > > GNU_CONFIGURE= yes > +# !!!!!!!!!!!! > +# Changing the localstatedir is a huge POLA violation. Please leave it alone. > +# !!!!!!!!!!!!!! > CONFIGURE_ARGS= --with-botan=${LOCALBASE} --with-sqlite3=${LOCALBASE} \ > --localstatedir=/var But surely you agree that using PREFIX/var instead of /var is a bug and ports that do so need to be fixed? The attached patch adds --localstatedir=/var to _LATE_CONFIGURE_ARGS (like --mandir). Maybe that would be better to prevent this problem in the future. --MP_/jScke2AY4HXiKdtZwVNitAb Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=b.p.m.localstatedir.patch Index: Mk/bsd.port.mk =================================================================== --- Mk/bsd.port.mk (revision 382989) +++ Mk/bsd.port.mk (working copy) @@ -813,7 +813,8 @@ FreeBSD_MAINTAINER= portmgr@FreeBSD.org # Default: ${PREFIX} # CONFIGURE_ARGS # - Pass these args to configure if ${HAS_CONFIGURE} is set. -# Default: "--prefix=${GNU_CONFIGURE_PREFIX} --infodir=${PREFIX}/${INFO_PATH} +# Default: "--prefix=${GNU_CONFIGURE_PREFIX} +# --infodir=${PREFIX}/${INFO_PATH} --localstatedir=/var # --mandir=${MANPREFIX}/man --build=${CONFIGURE_TARGET}" if # GNU_CONFIGURE is set, "CC=${CC} CFLAGS=${CFLAGS} # PREFIX=${PREFIX} INSTALLPRIVLIB=${PREFIX}/lib @@ -2709,6 +2710,9 @@ HAS_CONFIGURE= yes SET_LATE_CONFIGURE_ARGS= \ _LATE_CONFIGURE_ARGS="" ; \ + if ./${CONFIGURE_SCRIPT} --help 2>&1 | ${GREP} -- --localstatedir > /dev/null; then \ + _LATE_CONFIGURE_ARGS="$${_LATE_CONFIGURE_ARGS} --localstatedir=/var" ; \ + fi ; \ if [ ! -z "`./${CONFIGURE_SCRIPT} --help 2>&1 | ${GREP} -- '--mandir'`" ]; then \ _LATE_CONFIGURE_ARGS="$${_LATE_CONFIGURE_ARGS} --mandir=${GNU_CONFIGURE_MANPREFIX}/man" ; \ fi ; \ --MP_/jScke2AY4HXiKdtZwVNitAb--