From owner-cvs-all@FreeBSD.ORG Sat Mar 13 01:57:35 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0953B16A4CF; Sat, 13 Mar 2004 01:57:35 -0800 (PST) Received: from mailout11.sul.t-online.com (mailout11.sul.t-online.com [194.25.134.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 66C9843D45; Sat, 13 Mar 2004 01:57:34 -0800 (PST) (envelope-from Alexander@Leidinger.net) Received: from fwd08.aul.t-online.de by mailout11.sul.t-online.com with smtp id 1B25td-0003iM-0B; Sat, 13 Mar 2004 10:57:33 +0100 Received: from Andro-Beta.Leidinger.net (EXTROTZere0cnKyQgB0+3YRR2XDuqq-fqt2ATxdXkrvlkQuSb+x6Yg@[217.83.23.16]) by fmrl08.sul.t-online.com with esmtp id 1B25tQ-1iAnnE0; Sat, 13 Mar 2004 10:57:20 +0100 Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) i2D9vJ1K028623; Sat, 13 Mar 2004 10:57:19 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from Magellan.Leidinger.net (netchild@localhost [127.0.0.1]) i2D9vJPV005405; Sat, 13 Mar 2004 10:57:19 +0100 (CET) (envelope-from Alexander@Leidinger.net) Date: Sat, 13 Mar 2004 10:57:19 +0100 From: Alexander Leidinger To: cvs-src@freebsd.org Message-Id: <20040313105719.5e4e8765@Magellan.Leidinger.net> In-Reply-To: <20040312215649.GA4588@ip.net.ua> References: <200403122136.i2CLaCm9096276@repoman.freebsd.org> <20040312215649.GA4588@ip.net.ua> X-Mailer: Sylpheed version 0.9.9claws (GTK+ 1.2.10; i386-portbld-freebsd5.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Seen: false X-ID: EXTROTZere0cnKyQgB0+3YRR2XDuqq-fqt2ATxdXkrvlkQuSb+x6Yg@t-dialin.net cc: Tom Rhodes cc: src-committers@freebsd.org cc: Ruslan Ermilov cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/share/mk bsd.cpu.mk bsd.dep.mk bsd.lib.mk bsd.sys.mk src/sys/conf files kern.mk kern.pre.mk kmod.mk src/sys/dev/aic7xxx/aicasm Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Mar 2004 09:57:35 -0000 On Fri, 12 Mar 2004 23:56:49 +0200 Ruslan Ermilov wrote: > > Index: src/share/mk/bsd.lib.mk > > diff -u src/share/mk/bsd.lib.mk:1.156 src/share/mk/bsd.lib.mk:1.157 > > --- src/share/mk/bsd.lib.mk:1.156 Tue Jan 27 15:22:15 2004 > > +++ src/share/mk/bsd.lib.mk Fri Mar 12 13:36:12 2004 > [...] > > +.c.o: > > + ${CC} ${CFLAGS} -c ${.IMPSRC} -o ${.TARGET} > > + > > > Please revert the addition of this, it's bogus and duplicated > what's already in sys.mk. Ooops... sorry. I think this bogus change crept in at the time you moved this part to sys.mk (at least I think you did something like this, and I forgot to review your change entirely). > > @@ -157,7 +166,7 @@ > > ${LINT} ${LINTLIBFLAGS} ${CFLAGS:M-[DIU]*} ${.ALLSRC} > > .endif > > > > -.endif !defined(INTERNALLIB) > > +.endif #!defined(INTERNALLIB) > > > Please revert this. Why? .endif doesn't take an argument and it serves as a comment. So why not make it explicit? I would agree with adding a space after the comment sign, but I don't understand why it should be reverted. Thanks for the review, Alexander. -- I will be available to get hired in April 2004. http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7