Date: Thu, 24 Aug 2023 09:19:51 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Warner Losh <imp@bsdimp.com>, Jessica Clarke <jrtc27@freebsd.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 4a69fc16a583 - main - Add membarrier(2) Message-ID: <747e34d5-8191-5fb9-deb4-c94d7f1693e0@FreeBSD.org> In-Reply-To: <CANCZdfpqJM4dsyEFJt6P_Yf9WBJ9V3hYe8tVCipJr0pecsHekg@mail.gmail.com> References: <202308230007.37N07cOK082906@gitrepo.freebsd.org> <748B7A01-5011-44EE-BB04-282AE96F9B5B@freebsd.org> <ZOVxDqInEgUhBaIN@kib.kiev.ua> <0F3EA94D-6696-471C-ABF6-840B5E92967F@freebsd.org> <CANCZdfpqJM4dsyEFJt6P_Yf9WBJ9V3hYe8tVCipJr0pecsHekg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/23/23 6:01 AM, Warner Losh wrote: > On Tue, Aug 22, 2023 at 11:37 PM Jessica Clarke <jrtc27@freebsd.org> wrote: > >> >>> The addition does not change any existing code path in the kernel. >> >> No, but it commits us to a new syscall being stable just days before 14 >> branches and has its ABI frozen. >> > > I'd planned on committing timerfd later today. I didn't consider it an ABI > breakage, since it was just additive. It's one of the things that can be > MFC'd (we don't prohibit new system calls). (Not taking a side on the merits of the current membarrier(2) implementation) I think Jess's point here is not that a new syscall is not a valid ABI breakage, but more that once you add a new syscall that makes it into a release, now the ABI of that syscall is frozen and can't be changed. That said, syscall numbers are relatively "cheap", so if we had to renumber membarrier(2) because its ABI was found to be a problem that could be done, albeit at the cost of keeping the old one around under COMPAT_FREEBSD<n>. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?747e34d5-8191-5fb9-deb4-c94d7f1693e0>