From nobody Wed Feb 11 16:25:25 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fB3gp0qwTz6Rm9N for ; Wed, 11 Feb 2026 16:25:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fB3gn5gmQz413P for ; Wed, 11 Feb 2026 16:25:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770827125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CmXopGw5j/ss+hqXYirvb146ctwkC4uyrBqVZQXU3aA=; b=A4w9pGkN1xxlRJvTUTxCVxvb2NXy8WeAsMtKRPg7hXKsnYukRcYfL+mtSet8LAKrzDtEzh 6JSTozYinxlrNfOFVfZUVqumVP/GdA9yJmYJnsxKGOiLwUeF8UFJQFVXV29qs2CBYgqAFG uLCWwZO7SmOywAxDr+p8iE7GGLy3KXU0IPIv31zqCdlKpGj4YlOeMeCr2rcl3/uFBRb9YO ib+S3S3DcZrjczSYK3sS2LTs6pAUIBo1tEdpYoJ0OOCkWgaZ56PX4aM1KQka2putA78U7q W4AR29PsrVtbHPsa3aD7k36ELFXBU0e51+Ft+AyyoQfkMDd4Lk+3Ii0h2wvi0Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770827125; a=rsa-sha256; cv=none; b=ma3zkUWbzP2GYfsUR/OECr4iuAUnRPqTk9DyAKJnTafW+Kb460SxItvYe8nh6cwoVYii9o k1q4OW+28u+aDzVol+U7yUU0kKf91jsJdv+vMg0VRAd43zjhpiHuHTpNK1xhxE/49ieigr nPHBiN8INTF8gwSOUm7+pzw0D8CLLxMQCRaPZqFGDaX04k1Q7B3BvdAjJIrA5OeezhED9o F75G1wzupi3t5qAVc2XayNmIcBUPgw37swUSPDQeLfFHLJsL7yMFqMs2li4KKPzxEUj5fp 4heT3CKqdbHJ9B3daZRAJ3VtPBhU//jKkrzSn91kdOqNJcKZcf+lS5F0QNAOSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770827125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CmXopGw5j/ss+hqXYirvb146ctwkC4uyrBqVZQXU3aA=; b=dN0/k3IZdJwBV60Z2InVcxGg/8RzgpH/MvVM7z4L945IQi8GDwlqCYuq6UQUN789Df4MVO +VxDys2eNsYzs5vkjgfmChDGkUQXPeJgsYCs6nHe0WXcY9eH6kmZFjBgL98hvXt/YyI0p5 KFk75AV9FJmWfMuU8LCGElw8SRkOQiK5/YsvbBSfNlJKcBpdRaYHE71bMA2+Tm3kd9cZ1g BOM7ET8knyV5xCTLvf/m1oGvkmc9GFGG8hmW3n4rH/65fpjYBs9rYE/QAKyzDJZ4U8RShu Ukw880dArOrLO9CCnmNFo93zrmpMn23HYPZiyYYAe3nLP+OYrtG7VB70pdw2SQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fB3gn5DYszxd2 for ; Wed, 11 Feb 2026 16:25:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 259a9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 11 Feb 2026 16:25:25 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 71569594d860 - main - diff: Improve directory loop detection List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 71569594d860a59d8362770a56d806e1d31fb946 Auto-Submitted: auto-generated Date: Wed, 11 Feb 2026 16:25:25 +0000 Message-Id: <698cad75.259a9.24302262@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=71569594d860a59d8362770a56d806e1d31fb946 commit 71569594d860a59d8362770a56d806e1d31fb946 Author: Dag-Erling Smørgrav AuthorDate: 2026-02-11 16:24:54 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-11 16:24:54 +0000 diff: Improve directory loop detection When we're done processing a directory, remove its entry from the tree of visited inodes, ensuring that we only report a loop when we encounter a descendant-to-ancestor link, not when we encounter a cousin-to-cousin or sibling-to-sibling link. MFC after: 1 week Reported by: Bakul Shah Sponsored by: Klara, Inc. Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D55248 --- usr.bin/diff/diffdir.c | 20 +++++++++++++++++--- usr.bin/diff/tests/diff_test.sh | 5 +++++ 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/usr.bin/diff/diffdir.c b/usr.bin/diff/diffdir.c index 0e9beb80e6a1..489b873e2fcf 100644 --- a/usr.bin/diff/diffdir.c +++ b/usr.bin/diff/diffdir.c @@ -60,7 +60,8 @@ static struct inodetree v2 = RB_INITIALIZER(&v2); RB_GENERATE_STATIC(inodetree, inode, entry, inodecmp); static int -vscandir(struct inodetree *tree, const char *path, struct dirent ***dirp, +vscandir(struct inodetree *tree, struct inode **inop, + const char *path, struct dirent ***dirp, int (*selectf)(const struct dirent *), int (*comparf)(const struct dirent **, const struct dirent **)) { @@ -85,6 +86,7 @@ vscandir(struct inodetree *tree, const char *path, struct dirent ***dirp, goto fail; RB_INSERT(inodetree, tree, ino); close(fd); + *inop = ino; return (ret); fail: serrno = errno; @@ -96,6 +98,13 @@ fail: return (-1); } +static void +leavedir(struct inodetree *tree, struct inode *ino) +{ + RB_REMOVE(inodetree, tree, ino); + free(ino); +} + /* * Diff directory traversal. Will be called recursively if -r was specified. */ @@ -104,6 +113,7 @@ diffdir(char *p1, char *p2, int flags) { struct dirent *dent1, **dp1, **edp1, **dirp1 = NULL; struct dirent *dent2, **dp2, **edp2, **dirp2 = NULL; + struct inode *ino1 = NULL, *ino2 = NULL; size_t dirlen1, dirlen2; char path1[PATH_MAX], path2[PATH_MAX]; int pos; @@ -131,7 +141,7 @@ diffdir(char *p1, char *p2, int flags) * Get a list of entries in each directory, skipping "excluded" files * and sorting alphabetically. */ - pos = vscandir(&v1, path1, &dirp1, selectfile, alphasort); + pos = vscandir(&v1, &ino1, path1, &dirp1, selectfile, alphasort); if (pos == -1) { if (errno == ENOENT && (Nflag || Pflag)) { pos = 0; @@ -143,7 +153,7 @@ diffdir(char *p1, char *p2, int flags) dp1 = dirp1; edp1 = dirp1 + pos; - pos = vscandir(&v2, path2, &dirp2, selectfile, alphasort); + pos = vscandir(&v2, &ino2, path2, &dirp2, selectfile, alphasort); if (pos == -1) { if (errno == ENOENT && Nflag) { pos = 0; @@ -217,11 +227,15 @@ diffdir(char *p1, char *p2, int flags) closem: if (dirp1 != NULL) { + if (ino1 != NULL) + leavedir(&v1, ino1); for (dp1 = dirp1; dp1 < edp1; dp1++) free(*dp1); free(dirp1); } if (dirp2 != NULL) { + if (ino2 != NULL) + leavedir(&v2, ino2); for (dp2 = dirp2; dp2 < edp2; dp2++) free(*dp2); free(dirp2); diff --git a/usr.bin/diff/tests/diff_test.sh b/usr.bin/diff/tests/diff_test.sh index 6ca19a8f20cb..0d3acf50edf9 100755 --- a/usr.bin/diff/tests/diff_test.sh +++ b/usr.bin/diff/tests/diff_test.sh @@ -382,6 +382,11 @@ dirloop_body() -e match:"a/foo/bar/up: Directory loop detected" \ -e match:"b/foo/bar/up: Directory loop detected" \ diff -r a b + atf_check rm [ab]/foo/bar/up + atf_check mkdir -p b/foo/bar + atf_check ln -s foo a/baz + atf_check ln -s foo b/baz + atf_check diff -r a b } bigc_head()