From owner-p4-projects@FreeBSD.ORG Sun Apr 20 14:19:23 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 51C3C1065675; Sun, 20 Apr 2008 14:19:23 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CFBBA106566C for ; Sun, 20 Apr 2008 14:19:22 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id BDF9C8FC1A for ; Sun, 20 Apr 2008 14:19:22 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m3KEJMRT039245 for ; Sun, 20 Apr 2008 14:19:22 GMT (envelope-from hselasky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m3KEJMCl039243 for perforce@freebsd.org; Sun, 20 Apr 2008 14:19:22 GMT (envelope-from hselasky@FreeBSD.org) Date: Sun, 20 Apr 2008 14:19:22 GMT Message-Id: <200804201419.m3KEJMCl039243@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to hselasky@FreeBSD.org using -f From: Hans Petter Selasky To: Perforce Change Reviews Cc: Subject: PERFORCE change 140295 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Apr 2008 14:19:23 -0000 http://perforce.freebsd.org/chv.cgi?CH=140295 Change 140295 by hselasky@hselasky_laptop001 on 2008/04/20 14:18:21 Fix compiler warning. Affected files ... .. //depot/projects/usb/src/sys/dev/usb/ucom.c#30 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb/ucom.c#30 (text+ko) ==== @@ -205,8 +205,6 @@ ucom_bitmap[x / 8] |= (1 << (x % 8)); } - *p_root_unit = n; - error = 0; break; @@ -216,6 +214,12 @@ mtx_unlock(&Giant); + /* + * Always set the variable pointed to by "p_root_unit" so that + * the compiler does not think that it is used uninitialised: + */ + *p_root_unit = n; + return (error); }