From owner-svn-src-all@freebsd.org Wed Mar 8 22:39:10 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4A27DD03953; Wed, 8 Mar 2017 22:39:10 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1459B1B7A; Wed, 8 Mar 2017 22:39:09 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id v28Md8Uu004946 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 8 Mar 2017 14:39:09 -0800 (PST) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id v28Md8ps004945; Wed, 8 Mar 2017 14:39:08 -0800 (PST) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 8 Mar 2017 14:39:08 -0800 From: Gleb Smirnoff To: "Ngie Cooper (yaneurabeya)" Cc: Andriy Gapon , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r314862 - head/sys/modules/qlxgbe Message-ID: <20170308223908.GR1044@FreeBSD.org> References: <201703071543.v27FhnoL024242@repo.freebsd.org> <20170307221733.GN1044@FreeBSD.org> <70fcdcf4-cfa5-2382-ea60-55ac1a91e06b@FreeBSD.org> <20170308215514.GQ1044@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 22:39:10 -0000 On Wed, Mar 08, 2017 at 01:57:32PM -0800, Ngie Cooper (yaneurabeya) wrote: N> > On Wed, Mar 08, 2017 at 01:00:30AM +0200, Andriy Gapon wrote: N> > A> On 08/03/2017 00:17, Gleb Smirnoff wrote: N> > A> > On Tue, Mar 07, 2017 at 03:43:49PM +0000, Andriy Gapon wrote: N> > A> > A> Author: avg N> > A> > A> Date: Tue Mar 7 15:43:49 2017 N> > A> > A> New Revision: 314862 N> > A> > A> URL: https://svnweb.freebsd.org/changeset/base/314862 N> > A> > A> N> > A> > A> Log: N> > A> > A> qlxgbe: add GCC_MS_EXTENSIONS to CFLAGS to make old base GCC happy N> > A> > A> N> > A> > A> The module uses unnamed structure and union fields and base GCC in N> > A> > A> stable/10 doesn't like it. N> > A> > A> I think that that is a C11 feature, so it is courteous of more modern N> > A> > A> compilers to not complain about it when compiling in C99 mode. N> > A> > N> > A> > There are a lot of code in kernel, that uses anonymous structs and unions. N> > A> > This feature is enabled globally. Why does this module need special treatment? N> > A> N> > A> That's a good question and I don't have a good answer to it. N> > A> All I can say is that a GCC build of GENERIC and modules failed in that fashion N> > A> only for this module (in stable/10). N> > A> Maybe I described the problem incorrectly. Then, a proper explanation is welcome. N> > N> > In head this is fixed properly: N> > N> > https://svnweb.freebsd.org/base?view=revision&revision=278913 N> > N> > Can you please move your fix to stable/10 and revert it in head? N> N> I understand there might be conflicts, but wouldn’t it be better to revert and MFC the change you committed to ^/head (which is already in ^/stable/11) to ^/stable/10? Could be. But I intentionally avoided MFCing it back in 2015, in my humble opinion changing global compilation flags is something not for a stable branch. I defintely won't go for it, but anybody else welcome :) -- Totus tuus, Glebius.