From owner-freebsd-stable@FreeBSD.ORG  Tue Oct 28 16:56:11 2008
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5276E10656A4
	for <freebsd-stable@freebsd.org>; Tue, 28 Oct 2008 16:56:11 +0000 (UTC)
	(envelope-from josh.carroll@gmail.com)
Received: from yw-out-2324.google.com (yw-out-2324.google.com [74.125.46.30])
	by mx1.freebsd.org (Postfix) with ESMTP id 0D07C8FC16
	for <freebsd-stable@freebsd.org>; Tue, 28 Oct 2008 16:56:10 +0000 (UTC)
	(envelope-from josh.carroll@gmail.com)
Received: by yw-out-2324.google.com with SMTP id 9so643545ywe.13
	for <freebsd-stable@freebsd.org>; Tue, 28 Oct 2008 09:56:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:message-id:date:from:reply-to
	:to:subject:mime-version:content-type:content-transfer-encoding
	:content-disposition;
	bh=u1uaUXPW7i3AmGJHOfote2POx1tu8u5BbRsGEgKUpWk=;
	b=BsQb+k7k/P43Y2DQUBsyucdIq8mWk0iBj+pZ7YpWVXtbX3uJFh+CGr7AyzRbFNRYcK
	niIMxLQNikxXUa81Rh3vDfHCu2EAmzCsWnPA/ApVQWFwVqp4+FokgES5Z3Pw99PLQLyd
	F3U00Sik6Yz7MZlSYTCKqn9kWt2L81nlR1VBY=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:date:from:reply-to:to:subject:mime-version:content-type
	:content-transfer-encoding:content-disposition;
	b=e75JCpVWMGB8e3NPpDLmk/lMVDBgxiFCC6YbJXL5T7bzO9dOxvCYInEIuuY+cmtVMN
	foRwkm6lQazOhZmFGnUeSwP0fgFJ/D73K3uPZ92b0P+8o1zQlK2eVYVMCCmh4TG5jMpD
	TkdxqmrKG1KuinwAItI0d7bfZFonqQ8ryV4W0=
Received: by 10.151.12.4 with SMTP id p4mr8884868ybi.85.1225212970038;
	Tue, 28 Oct 2008 09:56:10 -0700 (PDT)
Received: by 10.151.11.21 with HTTP; Tue, 28 Oct 2008 09:56:10 -0700 (PDT)
Message-ID: <8cb6106e0810280956lf864bdbqe46120e2d6816125@mail.gmail.com>
Date: Tue, 28 Oct 2008 12:56:10 -0400
From: "Josh Carroll" <josh.carroll@gmail.com>
To: "FreeBSD Stable" <freebsd-stable@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Subject: src/lib/libc/stdlib/grantpt.c commit broke sshd
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: josh.carroll@gmail.com
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Oct 2008 16:56:11 -0000

I just built world from RELENG_7 sources csup'd this morning, and it
appears the change to src/lib/libc/stdlib/grantpt.c has broken sshd.

I see the following when I attempt to login:

Oct 28 12:32:34 pflog sshd[78236]: fatal: openpty returns device for
which ttyname fails.
Oct 28 12:32:34 pflog sshd[78236]: error: chown  0 0 failed: No such
file or directory
Oct 28 12:32:34 pflog sshd[78236]: error: chmod  0666 failed: No such
file or directory

If I back out the changes committed on 10/26 to grantpt.c, rebuild
libc and restart sshd, I can login again properly.

Here are the pty/tty related options in my kernel config:

device          pty             # Pseudo-ttys (telnet etc)

Note that I do not have:

options         COMPAT_43TTY

Is COMPAT_43TTY necessary after this commit?

Thanks,
Josh