From owner-svn-ports-all@freebsd.org Wed Sep 12 20:04:06 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB9ED109BE68; Wed, 12 Sep 2018 20:04:06 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1661A7048E; Wed, 12 Sep 2018 20:04:05 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id 0BMkgFaLyWppD0BMlgefog; Wed, 12 Sep 2018 14:03:59 -0600 X-Authority-Analysis: v=2.3 cv=YIcrNiOx c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=JBFolyDoGHsA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=U3-EEiRsmJAVDUFL-yIA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 16FB83B3; Wed, 12 Sep 2018 13:05:01 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w8CK3elp080535; Wed, 12 Sep 2018 13:03:40 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w8CK3egx080532; Wed, 12 Sep 2018 13:03:40 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201809122003.w8CK3egx080532@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Alexey Dokuchaev cc: Bernard Spil , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r479614 - in head/security/openssl111: . files In-Reply-To: Message from Alexey Dokuchaev of "Wed, 12 Sep 2018 16:20:33 -0000." <20180912162033.GA51342@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 12 Sep 2018 13:03:40 -0700 X-CMAE-Envelope: MS4wfJQFJNDLwStUbHwFteUjKzZwU+uIaCazlFA8KPWJiEJgsR+L/JPho7TblP6Uk3Cuq3M/8wLuKq4OriVc5tcQ1US8+Jg9Pa48m+MU/8sTBaC7IuM38xe4 Us/XetqbPRP0W4J9OzKJWMadMaoTwOTO0XhqU3fDBrE1to+TGp4xQQetlG/Xdp6oLEPJVs9gdqzl22PDYMLjeYxL6qBECzhN2M2fMHXUbRqeLrejTUglQOn9 aEt7NG0vtGnFrUAKOnkpvS5dCTsONLMO+Szc3Axiw822nws8dDA5QXSXPiKx8DWMBvHAcaJ5DCcttyV6OMiZF7dy1cXaTn8u0YFO/tWYw+FfyeoveWDnbTEy ujxl+oIv X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2018 20:04:07 -0000 In message <20180912162033.GA51342@FreeBSD.org>, Alexey Dokuchaev writes: > On Wed, Sep 12, 2018 at 04:11:11PM +0000, Bernard Spil wrote: > > New Revision: 479614 > > URL: https://svnweb.freebsd.org/changeset/ports/479614 > > > > Log: > > security/openssl111: Re-add OpenSSL 1.1.1 port > > > > ... > > .if ${PREFIX} == /usr > > -IGNORE= the OpenSSL port cannot be installed over the base version > > +IGNORE= the OpenSSL port can not be installed over the base version > > This change looks wrong: anything "can not be installed": you just don't > install it. > > > .if ${PORT_OPTIONS:MASM} > > -BROKEN_sparc64= option ASM generates illegal instructions > > +BROKEN_sparc64= option ASM generates illegal instructions > > This change is gratuitous. It appears it might have been a whitespace change. Whitespace changes and other formatting changes should be separate from substantial/functional/real code changes. When people review history they new must parse out formatting changes from real changes. Two years from now someone trying to figure out what the change actually was will spend two or five times the time sifting through the diff. Future developers will consider this POLA. I've been in this situation many times, not just here at FreeBSD but elsewhere too. It's a PITA. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.