Date: Wed, 9 Apr 2014 10:07:22 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: marino@freebsd.org Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Niclas Zeising <zeising@FreeBSD.org> Subject: Re: svn commit: r350341 - in head/x11-wm/spectrwm: . files Message-ID: <20140409100722.GA38933@FreeBSD.org> In-Reply-To: <53451882.50705@marino.st> References: <201404060745.s367j4nR058999@svn.freebsd.org> <20140409094935.GA32661@FreeBSD.org> <53451882.50705@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 09, 2014 at 11:53:06AM +0200, John Marino wrote: > On 4/9/2014 11:49, Alexey Dokuchaev wrote: > > On Sun, Apr 06, 2014 at 07:45:04AM +0000, Niclas Zeising wrote: > >> New Revision: 350341 > >> URL: http://svnweb.freebsd.org/changeset/ports/350341 > >> QAT: https://qat.redports.org/buildarchive/r350341/ > >> > >> @@ -1,6 +1,6 @@ > >> ---- spectrwm.c.orig 2013-04-29 23:55:24.573913339 +0200 > >> -+++ spectrwm.c 2013-04-29 23:55:44.031914326 +0200 > >> -@@ -6316,7 +6316,7 @@ > >> +--- spectrwm.c.orig 2014-04-06 09:43:33.000000000 +0200 > >> ++++ spectrwm.c 2014-04-06 09:43:33.000000000 +0200 > > > > Guys, (replying to one of the few similar emails) > > > > Please don't commit changes to patch files that only touch patch header, not > > file contents in any way. [...] > > How does this example qualify? > The offset changes by nearly 700 lines. > This is a valid patch change IMO. > Offsets are content. Right; mea culpa; sorry for the noise. However, if +++/--- lines were not touched, it would helped to spot the real difference easier. :) ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140409100722.GA38933>