Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 18 Jun 2012 20:19:07 +0000 (UTC)
From:      Marius Strobl <marius@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r237240 - head/sys/dev/flash
Message-ID:  <201206182019.q5IKJ7LL098727@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: marius
Date: Mon Jun 18 20:19:07 2012
New Revision: 237240
URL: http://svn.freebsd.org/changeset/base/237240

Log:
  Revert r236529, re-enabling verification of the flashed content as
  the underlying problem was dealt with in r237239 (in fact, disabling
  verification also actually only made the problem less likely to occur).

Modified:
  head/sys/dev/flash/at45d.c

Modified: head/sys/dev/flash/at45d.c
==============================================================================
--- head/sys/dev/flash/at45d.c	Mon Jun 18 20:14:42 2012	(r237239)
+++ head/sys/dev/flash/at45d.c	Mon Jun 18 20:19:07 2012	(r237240)
@@ -390,7 +390,6 @@ at45d_task(void *arg)
 				berr = EIO;
 				goto out;
 			}
-#ifdef notyet /* May cause physwr to hang for reasons unknown. */
 			if (bp->bio_cmd == BIO_WRITE) {
 				addr = page << sc->pageoffset;
 				txBuf[0] = BUFFER_COMPARE;
@@ -409,7 +408,6 @@ at45d_task(void *arg)
 					goto out;
 				}
 			}
-#endif
 			page++;
 			buf += len;
 			offset = 0;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206182019.q5IKJ7LL098727>