Date: Sun, 18 Jul 2004 20:30:18 GMT From: Rui Lopes <rui@ruilopes.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/68769: [PATCH] devel/maven: update to 1.0.r4 and MASTER_SITE_APACHE Message-ID: <200407182030.i6IKUID5094007@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/68769; it has been noted by GNATS.
From: Rui Lopes <rui@ruilopes.com>
To: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
Cc: Volker Stolz <stolz@i2.informatik.rwth-aachen.de>,
freebsd-gnats-submit@freebsd.org
Subject: Re: ports/68769: [PATCH] devel/maven: update to 1.0.r4 and MASTER_SITE_APACHE
Date: Sun, 18 Jul 2004 21:28:02 +0100
Hi,
Herve Quiroz wrote:
> On Sat, Jul 17, 2004 at 10:36:37PM +0100, Rui Lopes wrote:
>
>>See the attached patch, it contains all "fixes" from the discussion
>>and updates Maven to 1.0 final. If you are agree with it, lets have
>>this commited.
>
>
> I agree with it, excepted for some small problem I noticed. The
> following statement will not perform what you intend it to do:
>
> .for file in ${WRKSRC}/${dir}/*.jar
> <...>
> .endfor
>
> The star (*) is a shell wildcard and make will not expand it.
In the end it will do what we want too :)
[...]
> IMHO you may remove the nested loop by using the wildcard directly (just
> as it performs with your patch). I attached a patch (to be applied
> against Makefile from 1.0.r2).
Yes, apply this patch too.
-- Rui Lopes
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407182030.i6IKUID5094007>