From owner-cvs-ports@FreeBSD.ORG Mon May 23 18:16:26 2011 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from apollo.emma.line.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by hub.freebsd.org (Postfix) with ESMTP id 0C937106566B; Mon, 23 May 2011 18:16:26 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by apollo.emma.line.org (Postfix) with ESMTP id 0D5EA23DADD; Mon, 23 May 2011 20:16:25 +0200 (CEST) Message-ID: <4DDAA478.3030203@FreeBSD.org> Date: Mon, 23 May 2011 20:16:24 +0200 From: Matthias Andree User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110424 Mnenhy/0.8.3 Thunderbird/3.1.10 MIME-Version: 1.0 To: Alexey Dokuchaev References: <201105231554.p4NFsBdt024494@repoman.freebsd.org> <20110523170435.GA15903@FreeBSD.org> In-Reply-To: <20110523170435.GA15903@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/security/yara Makefile distinfo ports/security/yara/files patch-libyara__proc.c X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2011 18:16:26 -0000 Am 23.05.2011 19:04, schrieb Alexey Dokuchaev: > On Mon, May 23, 2011 at 03:54:11PM +0000, Wesley Shields wrote: >> wxs 2011-05-23 15:54:11 UTC >> >> Modified files: >> security/yara Makefile distinfo >> Added files: >> security/yara/files patch-libyara__proc.c >> Log: >> - Update to 1.5. >> - Switch to devel/re2 instead of PCRE. > > Could you perhaps explain the rationale behind pcre -> re2 (never heard > of it before) change? I mean, lots of ports depend on devel/pcre, which > seems to be de-facto regex library, and having two similar (well, that's > maybe an underestimation) libraries installed in a system without some > sufficiently strong reason seems at least questionable. (Unless, of > course, this port deliberately requires re2 and cannot be built against > pcre or easily converted.) Alexey, re2 is a different beast, and in particular, isn't prone to combinatorial explosion and exponential worst-case behaviour. Check its home page, http://code.google.com/p/re2/ -- also, PCRE is questionable because the standard regexp matcher is regex.h/libc. Now what? :) Seriously, we should question the use of software that has awkward worst-case behaviour... HTH Matthias