From owner-svn-ports-all@FreeBSD.ORG Wed Jan 22 09:16:15 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 72D7ECEE; Wed, 22 Jan 2014 09:16:15 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2DE8311B5; Wed, 22 Jan 2014 09:16:15 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id A4915BDC5D; Wed, 22 Jan 2014 10:16:12 +0100 (CET) Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gw.in.absolight.net", Issuer "CA Cert Signing Authority" (not verified)) by prod2.absolight.net (Postfix) with ESMTPSA id 6E4AEBDC56; Wed, 22 Jan 2014 10:16:12 +0100 (CET) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) by gw.in.absolight.net (Postfix) with ESMTP id E89F0613F; Wed, 22 Jan 2014 10:16:11 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by ogg.in.absolight.net (Postfix) with ESMTP id 76C04682EA4E; Wed, 22 Jan 2014 10:16:11 +0100 (CET) Date: Wed, 22 Jan 2014 10:16:11 +0100 From: Mathieu Arnold To: Alex Dupre , Alexey Dokuchaev Subject: Re: svn commit: r340618 - head/security/cryptlib Message-ID: <1EEC25E6DEEADBD0368A62DD@ogg.in.absolight.net> In-Reply-To: <5CC219416A3809A85702532B@ogg.in.absolight.net> References: <201401211633.s0LGXRLP049969@svn.freebsd.org> <20140122013352.GA12715@FreeBSD.org> <52DF7EBE.3080103@FreeBSD.org> <5CC219416A3809A85702532B@ogg.in.absolight.net> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jan 2014 09:16:15 -0000 +--On 22 janvier 2014 10:01:43 +0100 Mathieu Arnold wrote: | +--On 22 janvier 2014 09:18:06 +0100 Alex Dupre wrote: || Alexey Dokuchaev ha scritto: ||>> +OPTIONS_DEFINE= DOCS ||> ||> Couple of observations. :) ||> ||> OPTIONS are normally placed below all other knobs (traditionally). || || Hmm, no :-) || ||>> + ${LN} -sf ${PREFIX}/lib/libcl.so.${PORTVERSION} ||>> ${STAGEDIR}${PREFIX}/lib/libcl.so.3 + ${LN} -sf ||>> ${PREFIX}/lib/libcl.so.3 ${STAGEDIR}${PREFIX}/lib/libcl.so ||> ||> Per our own wiki.freebsd.org/ports/StageDir: ||> ||> "When creating a symlink, prepend ${STAGEDIR} to the target path only ||> (and generally try to avoid using absolute paths in source). [...] || || You are right here, but I didn't change the source. Improved. | | Actually, it could have been only | | ${LN} -sf libcl.so.${PORTVERSION} ${STAGEDIR}${PREFIX}/lib/libcl.so.3 | ${LN} -sf libcl.so.3 ${STAGEDIR}${PREFIX}/lib/libcl.so | | They're in the same directory, the symlinks would resolve just fine. Which is what Alexey said, yes. -- Mathieu Arnold