Date: Sun, 28 Feb 2016 12:20:09 +0000 From: Brooks Davis <brooks@freebsd.org> To: Slawa Olhovchenkov <slw@zxy.spb.ru> Cc: Bryan Drewery <bdrewery@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org Subject: Re: svn commit: r296146 - stable/9/sys/dev/filemon Message-ID: <20160228122008.GA27425@spindle.one-eyed-alien.net> In-Reply-To: <20160228102728.GA94639@zxy.spb.ru> References: <201602272057.u1RKvYfF035338@repo.freebsd.org> <20160228102728.GA94639@zxy.spb.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 28, 2016 at 01:27:28PM +0300, Slawa Olhovchenkov wrote: > On Sat, Feb 27, 2016 at 08:57:34PM +0000, Bryan Drewery wrote: >=20 > > Author: bdrewery > > Date: Sat Feb 27 20:57:34 2016 > > New Revision: 296146 > > URL: https://svnweb.freebsd.org/changeset/base/296146 > >=20 > > Log: > > MFC r242088: > > =20 > > Desupport pre-FreeBSD 7.1. > >=20 > > Modified: > > stable/9/sys/dev/filemon/filemon.c > > Directory Properties: > > stable/9/sys/ (props changed) > > stable/9/sys/dev/ (props changed) > > -#if __FreeBSD_version < 701000 >=20 > Not specialy to this commit, just for information: what purpose to > have in src tree, already divided to branches, pieces of code under > #if? >=20 > Of couse, question not about external maintained code. Filemon started as externally maintained code and initially it was a bit ambiguous which direction changes would flow. Sometimes it's also useful to allow code in HEAD to just work when copied to stable so people can see if their problem is fixed without having to merge too much. In general though, we should remove code like this in things maintained entirely in tree. -- Brooks --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJW0uX3AAoJEKzQXbSebgfAlNIIAKCcVI5XPitD/GJoiddzvm2A Kcg7SH0KBA6TkUwMxGqeaW+zzgSgsPqXD1AmNhvpaSexG9Ue5VqsOJoxakajEvAt j5ZE7ypUAq6neNb4gXoNHEmyIH/1fKLsC87QFhkCP49AAi+gga9ywcD0g9df9N+m m9ZOpAJwLRe/NBI1AnKMeNylvCL9jp9u1Cgi7oXOc2SjquemkR90X+KszhH5E/j+ LFRsPdMdoFZ7pg7stQ8QYNHY1rGZ+LsNZb342kK77UgsNYyevi/SEgGdwfVD5zN5 6iuoW1zXrUGppRkey9Z0OPVaEgPVxQimjtQi83ESMYlmA/IFQBx0TO3Gg01+I40= =mXzP -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160228122008.GA27425>