From owner-freebsd-dtrace@FreeBSD.ORG Tue Oct 29 21:22:14 2013 Return-Path: Delivered-To: dtrace@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 80FE84E1; Tue, 29 Oct 2013 21:22:14 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id A506028ED; Tue, 29 Oct 2013 21:22:13 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id XAA15866; Tue, 29 Oct 2013 23:22:12 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1VbGjr-0005xh-Vy; Tue, 29 Oct 2013 23:22:12 +0200 Message-ID: <527026B3.2070309@FreeBSD.org> Date: Tue, 29 Oct 2013 23:20:51 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Mark Johnston Subject: Re: "unstable" sdt probes References: <5268F461.7080504@FreeBSD.org> <20131024161620.GA1710@charmander> <526A9CB5.2050207@FreeBSD.org> <20131026180643.GA98676@raichu> In-Reply-To: <20131026180643.GA98676@raichu> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: dtrace@FreeBSD.org X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Oct 2013 21:22:14 -0000 on 26/10/2013 21:06 Mark Johnston said the following: > The patch here is what I had in mind: > http://people.freebsd.org/~markj/patches/zfs_probes.diff > > I've only compile-tested it, but it should create illumos-compatible ZFS > probes without changing any ZFS code, assuming I understand exactly how > they're creating/naming probes. :) The simplicity and straightforwardness of your patch is very seducing! :-) I think that you missed sys/cddl/compat/opensolaris/sys/sdt.h, but that's a very a minor issue that is trivial to fix. I had something a little bit more elaborate on my mind. Something that would allow DTRACE_PROBE macros to work without providing any additional code per each probe. And also something that would make DTRACE_PROBE macros appealing to use in the FreeBSD code proper. So, I got some time to hack on this and here is a result: http://people.freebsd.org/~avg/dtrace-probe-macros.diff This change depends upon another change that I've just posted. So, no surprise that I feel preference for my change, but I think that your change has certain advantage as well (esp. brevity and clarity). What do you think? Thank you! -- Andriy Gapon