From owner-freebsd-arch@FreeBSD.ORG Fri Mar 14 16:22:42 2008 Return-Path: Delivered-To: arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B805D106566C for ; Fri, 14 Mar 2008 16:22:42 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 88E5B8FC15 for ; Fri, 14 Mar 2008 16:22:42 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m2EGKrjh098511 for ; Fri, 14 Mar 2008 10:20:54 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 14 Mar 2008 10:21:37 -0600 (MDT) Message-Id: <20080314.102137.-2034679600.imp@bsdimp.com> To: arch@FreeBSD.org From: "M. Warner Losh" X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Fri_Mar_14_10_21_37_2008_059)--" Content-Transfer-Encoding: 7bit Cc: Subject: BUS_DMA_ISA unused, planning on removing X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Mar 2008 16:22:42 -0000 ----Next_Part(Fri_Mar_14_10_21_37_2008_059)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Greetings, It appears that BUS_DMA_ISA is unused: find . -name \*.c -o -name \*.h | xargs egrep BUS_DMA_ISA ./ia64/isa/isa_dma.c: /*flags*/BUS_DMA_ISA, ./sys/bus_dma.h:#define BUS_DMA_ISA 0x400 /* map memory for AXP ISA dma */ I talked to Marcel, and he's cool with removing it. Can anybody see a reason not to GC this? Warner ----Next_Part(Fri_Mar_14_10_21_37_2008_059)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="bus-dma-isa.diff" Index: ia64/isa/isa_dma.c =================================================================== RCS file: /pe/ncvs/src/sys/ia64/isa/isa_dma.c,v retrieving revision 1.10 diff -u -r1.10 isa_dma.c --- ia64/isa/isa_dma.c 9 Jul 2007 04:58:16 -0000 1.10 +++ ia64/isa/isa_dma.c 14 Mar 2008 16:17:39 -0000 @@ -106,7 +106,7 @@ /*filter*/NULL, /*filterarg*/NULL, /*maxsize*/bouncebufsize, /*nsegments*/1, /*maxsegz*/0x3ffff, - /*flags*/BUS_DMA_ISA, + /*flags*/0, /*lockfunc*/busdma_lock_mutex, /*lockarg*/&Giant, &dma_tag[chan]) != 0) { Index: sys/bus_dma.h =================================================================== RCS file: /pe/ncvs/src/sys/sys/bus_dma.h,v retrieving revision 1.30 diff -u -r1.30 bus_dma.h --- sys/bus_dma.h 3 Sep 2006 00:26:17 -0000 1.30 +++ sys/bus_dma.h 14 Mar 2008 16:17:17 -0000 @@ -101,7 +101,6 @@ */ #define BUS_DMA_NOWRITE 0x100 #define BUS_DMA_NOCACHE 0x200 -#define BUS_DMA_ISA 0x400 /* map memory for AXP ISA dma */ /* Forwards needed by prototypes below. */ struct mbuf; ----Next_Part(Fri_Mar_14_10_21_37_2008_059)----