From owner-svn-src-head@freebsd.org Tue Oct 6 08:05:20 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7F8BB42B751; Tue, 6 Oct 2020 08:05:20 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C594c2rplz46g3; Tue, 6 Oct 2020 08:05:20 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 41C7A23A8C; Tue, 6 Oct 2020 08:05:20 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 09685K5m009788; Tue, 6 Oct 2020 08:05:20 GMT (envelope-from bapt@FreeBSD.org) Received: (from bapt@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 09685J6l009787; Tue, 6 Oct 2020 08:05:19 GMT (envelope-from bapt@FreeBSD.org) Message-Id: <202010060805.09685J6l009787@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: bapt set sender to bapt@FreeBSD.org using -f From: Baptiste Daroussin Date: Tue, 6 Oct 2020 08:05:19 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r366471 - head/usr.bin/backlight X-SVN-Group: head X-SVN-Commit-Author: bapt X-SVN-Commit-Paths: head/usr.bin/backlight X-SVN-Commit-Revision: 366471 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2020 08:05:20 -0000 Author: bapt Date: Tue Oct 6 08:05:19 2020 New Revision: 366471 URL: https://svnweb.freebsd.org/changeset/base/366471 Log: backlight: accept '%' in the brightness input value Improve friendlyness of the command line by accepting the percent brightness in both format: with or without a trailing '%' Reviewed by: manu Differential Revision: https://reviews.freebsd.org/D26692 Modified: head/usr.bin/backlight/backlight.8 head/usr.bin/backlight/backlight.c Modified: head/usr.bin/backlight/backlight.8 ============================================================================== --- head/usr.bin/backlight/backlight.8 Tue Oct 6 06:45:52 2020 (r366470) +++ head/usr.bin/backlight/backlight.8 Tue Oct 6 08:05:19 2020 (r366471) @@ -22,7 +22,7 @@ .\" .\" $FreeBSD$ .\" -.Dd October 02, 2020 +.Dd October 06, 2020 .Dt BACKLIGHT 8 .Os .Sh NAME @@ -63,6 +63,7 @@ When querying the brightness level only print the valu Query information about the backlight (name, type). .It Ar value Set the brightness level to this value, must be between 0 and 100. +A trailing '%' is valid. .It Ar incr | + .Op Ar value Decrement the backlight level. Modified: head/usr.bin/backlight/backlight.c ============================================================================== --- head/usr.bin/backlight/backlight.c Tue Oct 6 06:45:52 2020 (r366470) +++ head/usr.bin/backlight/backlight.c Tue Oct 6 08:05:19 2020 (r366471) @@ -144,6 +144,9 @@ main(int argc, char *argv[]) action = BACKLIGHT_SET_BRIGHTNESS; if (argc == 1) { + /* ignore a trailing % for user friendlyness */ + if (argv[0][strlen(argv[0]) - 1] == '%') + argv[0][strlen(argv[0]) - 1] = '\0'; percent = strtonum(argv[0], 0, 100, &percent_error); if (percent_error) errx(1, "Cannot parse brightness level %s: %s",