From owner-freebsd-virtualization@FreeBSD.ORG  Sat Jul 12 07:53:33 2008
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: freebsd-virtualization@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CE87D1065673
	for <freebsd-virtualization@freebsd.org>;
	Sat, 12 Jul 2008 07:53:33 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outK.internet-mail-service.net (outk.internet-mail-service.net
	[216.240.47.234])
	by mx1.freebsd.org (Postfix) with ESMTP id B51448FC15
	for <freebsd-virtualization@freebsd.org>;
	Sat, 12 Jul 2008 07:53:33 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id 776F32352;
	Sat, 12 Jul 2008 00:53:33 -0700 (PDT)
Received: from julian-mac.elischer.org (localhost [127.0.0.1])
	by idiom.com (Postfix) with ESMTP id F23172D6319;
	Sat, 12 Jul 2008 00:53:32 -0700 (PDT)
Message-ID: <487862DB.1040904@elischer.org>
Date: Sat, 12 Jul 2008 00:52:59 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421)
MIME-Version: 1.0
To: James Gritton <jamie@gritton.org>
References: <487787CC.6020302@gritton.org>
In-Reply-To: <487787CC.6020302@gritton.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-virtualization@freebsd.org
Subject: Re: Simpler Vimage sysctls
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
	<freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Jul 2008 07:53:33 -0000

James Gritton wrote:
> While working on combining jail_set and Vimage, I found that the sysctl 
> virtualization hacks were more complicated than they needed to be.
> 
> The extra "subs" and "mod" arguments in SYSCTL_HANDLER_V_ARGS don't need 
> to be explicitly passed because they're members of the sysctl_v_oid 
> structure passed in the oidp argument.  By using oidp->oid_v_subs 
> instead of subs (and same for mod), SYSCTL_HANDLER_V_ARGS becomes the 
> same as SYSCTL_HANDLER_ARGS, and no longer need to be defined.
> 
> With the handlers now taking the same arguments, the sysctl_oid and 
> sysctl_v_oid structures become identical and sysctl_v_oid can go away.


looking at this I see what you are saying, and it looks odd that
there is a
         short           oid_v_subs;
         short           oid_v_mod;

even in the non VIMAGE case.. and in the non vimage struct.

I do wonder if Marko started moving towards this already and got 
stopped for some reason.

Marko?