From owner-cvs-src@FreeBSD.ORG  Tue Sep 19 18:27:59 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4BD9116A492;
	Tue, 19 Sep 2006 18:27:59 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 86E9F43D5F;
	Tue, 19 Sep 2006 18:27:53 +0000 (GMT)
	(envelope-from jkim@FreeBSD.org)
Received: from niksun.com (anuket [10.70.0.5])
	by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id k8JIRive053100;
	Tue, 19 Sep 2006 14:27:44 -0400 (EDT)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: John Baldwin <jhb@FreeBSD.org>
Date: Tue, 19 Sep 2006 14:27:29 -0400
User-Agent: KMail/1.6.2
References: <200609182218.k8IMIMUT059300@repoman.freebsd.org>
	<200609191232.54332.jhb@freebsd.org>
In-Reply-To: <200609191232.54332.jhb@freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200609191427.31736.jkim@FreeBSD.org>
X-Virus-Scanned: ClamAV 0.88/1900/Tue Sep 19 13:32:20 2006 on
	anuket.mj.niksun.com
X-Virus-Status: Clean
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/bge if_bge.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Sep 2006 18:27:59 -0000

On Tuesday 19 September 2006 12:32 pm, John Baldwin wrote:
> On Monday 18 September 2006 18:18, Jung-uk Kim wrote:
> > jkim        2006-09-18 22:18:22 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/dev/bge          if_bge.c
> >   Log:
> >   Do not strip VLAN tag in promiscuous mode.
>
> Why did you change this?  Does bge not work correctly with both
> enabled?

It does work.  Only problem is that VLAN tags are stripped before 
reaching bpf.  Thus, applications like tcpdump and wireshark don't 
see the VLAN tags.

http://docs.freebsd.org/cgi/mid.cgi?9256D57F598E6C41B288AA7DB94F29C902DFB963
http://docs.freebsd.org/cgi/mid.cgi?200410121035.59905.jkim

As I said earlier, it is just a stopgap until we teach bpf to insert 
VLAN tags back.  In fact, my intention was to MFC this before 6.2 
release and to fix -CURRENT when we have correct implementation 
because I don't think we can add the 'feature' in time.  If every one 
dislikes this, I have no problem backing it out, of course.

Jung-uk Kim