From owner-svn-ports-all@freebsd.org  Fri Jan 29 04:03:19 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 40CCDA725B1;
 Fri, 29 Jan 2016 04:03:19 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 36A66117B;
 Fri, 29 Jan 2016 04:03:19 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 34CE91119; Fri, 29 Jan 2016 04:03:19 +0000 (UTC)
Date: Fri, 29 Jan 2016 04:03:19 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Adam Weinberger <adamw@adamw.org>
Cc: Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r407331 - head/net/geoipupdate
Message-ID: <20160129040319.GA58352@FreeBSD.org>
References: <201601270116.u0R1G1Vl041516@repo.freebsd.org>
 <20160129015402.GA96343@FreeBSD.org>
 <17E923F7-F432-46B5-BF9F-C77D3BB9B0BE@adamw.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <17E923F7-F432-46B5-BF9F-C77D3BB9B0BE@adamw.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jan 2016 04:03:19 -0000

On Thu, Jan 28, 2016 at 08:51:55PM -0700, Adam Weinberger wrote:
> > On 28 Jan, 2016, at 18:54, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
> > On Wed, Jan 27, 2016 at 01:16:01AM +0000, Adam Weinberger wrote:
> >> New Revision: 407331
> >> URL: https://svnweb.freebsd.org/changeset/ports/407331
> >> 
> >> [...]
> >> @@ -1,4 +1,4 @@
> >> bin/geoipupdate
> >> -@sample etc/GeoIP.conf.sample
> >> +@sample etc/GeoIP.conf etc/GeoIP.conf.default
> > 
> > I think you've got it backwards, per what I read in CHANGE@20150926 and
> > running post-install() from +MANIFEST with commands prepended with echo:
> > [...]
> 
> Oh! You're totally right. I got confused by the wording from the
> porters-handbook.
> 
> "@sample file [file]" doesn't do much to resolve ambiguity :-P

Yes, I agree that "@sample file [file]" is not the best wording.  But in
that section 7.3, there's a Note with correct and more clear example.

> I'd suggest adding, after the first paragraph of 7.6.9:
> 
> 	So,
> 		@sample etc/myapp.conf.sample
> 	and
> 		@sample etc/myapp.conf.sample etc/myapp.conf
> 	are equivalent.

Yeah, perhaps some clarification of this sort could be helpful.

./danfe