From owner-freebsd-ports@FreeBSD.ORG  Thu Aug 12 17:33:25 2010
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D3DCD1065694;
	Thu, 12 Aug 2010 17:33:25 +0000 (UTC)
	(envelope-from kamikaze@bsdforen.de)
Received: from mail.bsdforen.de (bsdforen.de [212.204.60.79])
	by mx1.freebsd.org (Postfix) with ESMTP id 8FBE38FC14;
	Thu, 12 Aug 2010 17:33:25 +0000 (UTC)
Received: from mobileKamikaze.norad (df01ppp081.eplus-online.de
	[212.23.104.81])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.bsdforen.de (Postfix) with ESMTP id C75268A243B;
	Thu, 12 Aug 2010 19:33:18 +0200 (CEST)
Message-ID: <4C64304F.2090802@bsdforen.de>
Date: Thu, 12 Aug 2010 19:33:03 +0200
From: Dominic Fandrey <kamikaze@bsdforen.de>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-GB;
	rv:1.9.1.11) Gecko/20100722 Thunderbird/3.0.6
MIME-Version: 1.0
To: Doug Barton <dougb@FreeBSD.org>
References: <AANLkTinBJo0M-5fL=ATeY0KXnjA3O-7=TOLMF0X6dzdC@mail.gmail.com>	<4C5BC280.1070805@FreeBSD.org>	<AANLkTinfXC+4J-ZVyUShqKNS3AgpXgwDtnMjVx=iSo9K@mail.gmail.com>	<4C5BF352.5050004@dataix.net>
	<4C5C7DFF.8020400@FreeBSD.org>
In-Reply-To: <4C5C7DFF.8020400@FreeBSD.org>
X-Enigmail-Version: 1.0.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: ports@freebsd.org
Subject: Re: i keep *trying* to move from portupgrade to portmaster
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Aug 2010 17:33:25 -0000

On 06/08/2010 23:26, Doug Barton wrote:
> On 08/06/2010 04:34, jhell wrote:
> 
>> Do not prompt for a backup package creation failure
> 
> I need to add an option for this, but it will likely be an "expert"
> option that you can set in the rc file. The theory is that package
> creation failure should be a rare thing, and since portmaster has no way
> to know what packages are really critical to any given system it treats
> inability to safely recover from an upgrade failure as a critical error.
> However, having the ability to disable this is an oft-requested feature,
> I just haven't gotten to it yet.

Maybe you could treat pkg_create's return value 2 special, that's
what pkg_upgrade does.

Return value 2 means that creating a backup was successful, but
incomplete because of missing files. All the more reason to replace
the package in my opinion.

It's the most common case and it has no influence on portmaster's
ability to return the original state if something goes wrong, so
there's really no need to treat it differently from return value 0.

-- 
A: Because it fouls the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?