From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Oct 5 11:40:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C26279B6 for ; Sat, 5 Oct 2013 11:40:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 89D432B7B for ; Sat, 5 Oct 2013 11:40:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r95Be09d012971 for ; Sat, 5 Oct 2013 11:40:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r95Be0r5012970; Sat, 5 Oct 2013 11:40:00 GMT (envelope-from gnats) Resent-Date: Sat, 5 Oct 2013 11:40:00 GMT Resent-Message-Id: <201310051140.r95Be0r5012970@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mamoru Iwaki <1wkmmr@gmail.com> Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id CE3987F5 for ; Sat, 5 Oct 2013 11:32:14 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BB1DB2B46 for ; Sat, 5 Oct 2013 11:32:14 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r95BWEV5083070 for ; Sat, 5 Oct 2013 11:32:14 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r95BWEdl083069; Sat, 5 Oct 2013 11:32:14 GMT (envelope-from nobody) Message-Id: <201310051132.r95BWEdl083069@oldred.freebsd.org> Date: Sat, 5 Oct 2013 11:32:14 GMT From: Mamoru Iwaki <1wkmmr@gmail.com> To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/182680: set-get confusion in a patch X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Oct 2013 11:40:00 -0000 >Number: 182680 >Category: ports >Synopsis: set-get confusion in a patch >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Oct 05 11:40:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Mamoru Iwaki >Release: FreeBSD 9.2-STABLE >Organization: >Environment: >Description: Re: # $FreeBSD: haed/audio/xoscope/Makefile 326090 2013-09-02 21:16:30Z bapt $ I have just looked around audio/xoscope, not compiling it yet. Then, I found a strange line in files/patch-ser_unix.c, as follows: 34 +#ifdef BSD 35 + if (tcgetattr(fd, &svbuf) < 0 ) { 36 +#else 37 if (ioctl(fd, TCSETA, &svbuf) < 0) { 38 +#endif I wonder tcgetattr(...) in line 35 should be tcsetattr(...). Cheers >How-To-Repeat: >Fix: I believe that the line 35 of files/patch-ser_unix.c should be 'set' as follows. 35 + if (tcsetattr(fd, &svbuf) < 0 ) { >Release-Note: >Audit-Trail: >Unformatted: