From owner-freebsd-threads@FreeBSD.ORG  Thu Sep 21 07:30:37 2006
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
X-Original-To: freebsd-threads@hub.freebsd.org
Delivered-To: freebsd-threads@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AA07816A407
	for <freebsd-threads@hub.freebsd.org>;
	Thu, 21 Sep 2006 07:30:37 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6178A43D6A
	for <freebsd-threads@hub.freebsd.org>;
	Thu, 21 Sep 2006 07:30:26 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k8L7UPdg037245
	for <freebsd-threads@freefall.freebsd.org>;
	Thu, 21 Sep 2006 07:30:25 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k8L7UPoY037244;
	Thu, 21 Sep 2006 07:30:25 GMT (envelope-from gnats)
Date: Thu, 21 Sep 2006 07:30:25 GMT
Message-Id: <200609210730.k8L7UPoY037244@freefall.freebsd.org>
To: freebsd-threads@FreeBSD.org
From: Anders Nordby <anders@fupp.net>
Cc: 
Subject: Re: threads/103127: Kernel panic while using thread features in
	Squid 2.6
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Anders Nordby <anders@fupp.net>
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Sep 2006 07:30:37 -0000

The following reply was made to PR kern/103127; it has been noted by GNATS.

From: Anders Nordby <anders@fupp.net>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-threads@FreeBSD.org,
	Thomas-Martin Seck <tmseck@netcologne.de>,
	Suleiman Souhlal <ssouhlal@FreeBSD.org>
Cc:  
Subject: Re: threads/103127: Kernel panic while using thread features in Squid 2.6
Date: Thu, 21 Sep 2006 09:24:09 +0200

 Hi,
 
 On Sat, Sep 16, 2006 at 01:59:08PM -0700, John-Mark Gurney wrote:
 > Please try the attached patch.. It appears that the badfo_kqfilter was
 > returning sucess instead of error since it was introcuded many years
 > ago...  This many still cause other problems w/ squid, but will fix
 > the panics...
 > --- kern_descrip.c	21 Jul 2006 20:24:00 -0000	1.297
 > +++ kern_descrip.c	16 Sep 2006 20:58:40 -0000
 > @@ -2632,7 +2632,7 @@
 >  badfo_kqfilter(struct file *fp, struct knote *kn)
 >  {
 >  
 > -	return (0);
 > +	return (EINVAL);
 >  }
 >  
 >  static int
 
 This patch fixes the kernel panics that I have reported about in this
 PR. I have 9 cache servers with Squid2.6 that had this problem. After
 patching them, one by one, they haven't had any panics anymore.
 
 Cheers,
 
 -- 
 Anders.