Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Dec 2010 11:14:14 -0700
From:      John Hein <jhein@symmetricom.com>
To:        gecko@freebsd.org
Subject:   [patch] www/libxul/Makefile syntax error
Message-ID:  <19727.40182.87570.306554@gossamer.timing.com>

next in thread | raw e-mail | index | archive | help
There is a syntax error (since 2010/08/08) in www/libxul/Makefile that
is silently ignored.

The effects are that -pthread is not added to EXTRA_DSO_LDOPTS
in storage/build/Makefile.  It may be that the %%PTHREAD_LIBS%%
patch just isn't needed at all, but I haven't verified that.

This patch (below) fixes the syntax error.

It's possible that an alternative is to remove
files/patch-storage_build_Makefile.in and GECKO_PTHREAD_LIBS related
stuff in the Makefile.

Index: Makefile
===================================================================
RCS file: /base/FreeBSD-CVS/ports/www/libxul/Makefile,v
retrieving revision 1.24
diff -u -p -r1.24 Makefile
--- Makefile	10 Dec 2010 16:57:23 -0000	1.24
+++ Makefile	20 Dec 2010 18:01:46 -0000
@@ -51,8 +51,7 @@ OPTIONS=	DBUS "Enable D-BUS support" on
 
 .include <bsd.port.pre.mk>
 
-GECKO_PTHREAD_LIBS!=${CC} -dumpspecs | ${GREP} -m 1 '%{\!pg: %{pthread:' | ${SED
-} -e 's|^.*%{\!pg: %{pthread:|| ; s|}.*$$||' || ${TRUE}
+GECKO_PTHREAD_LIBS!=${CC} -dumpspecs | ${GREP} -m 1 '%{\!pg: %{pthread:' | ${SED} -e 's|^.*%{\!pg: %{pthread:|| ; s|}.*$$||' || ${TRUE}
 
 .if ${OSVERSION} < 700000
 LIB_DEPENDS+=	pulse.0:${PORTSDIR}/audio/pulseaudio



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19727.40182.87570.306554>