From owner-freebsd-current@FreeBSD.ORG Tue Jun 10 16:02:56 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 968E210657CD for ; Tue, 10 Jun 2008 16:02:56 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from yw-out-2324.google.com (yw-out-2324.google.com [74.125.46.31]) by mx1.freebsd.org (Postfix) with ESMTP id 5713A8FC50 for ; Tue, 10 Jun 2008 16:02:56 +0000 (UTC) (envelope-from onemda@gmail.com) Received: by yw-out-2324.google.com with SMTP id 9so1337009ywe.13 for ; Tue, 10 Jun 2008 09:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=emBjCmQ4Qs9ptDuE63cBErC3qPfIuoOETiDogPX/J4s=; b=oxoWoWs1fHtMOF7QF+YLxhV1gMR1Yo6Rm54zQ/AgnjKuMMY5LrvshTN2MoirVYXvhV un2342Q8LNhp3dkCL/IWHRHybo5ShaP2Xl/q1q3dUQanGiVbQQSzpzXxPFeWZTbq0EDJ 2f+07nmAQNtyGK0C87x4knEpQhbELYhseEB20= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=Rq0lB3tHitwgKukHImlWAE1wcFVwO8dMaI5deaIgBIZyPjDuj4kCwGlRoDCXrp8uOL gAWIw1lWD4vq0JlMhOOYySwIOnF3glr+FbhWgT1QzoJEMCk5uL5RJsF+bdFds+md/e5z gI9cvz1b4w12ldfYx2guvcDSFO5V2PlxV4lUw= Received: by 10.143.8.17 with SMTP id l17mr2132442wfi.106.1213113775053; Tue, 10 Jun 2008 09:02:55 -0700 (PDT) Received: by 10.142.199.19 with HTTP; Tue, 10 Jun 2008 09:02:55 -0700 (PDT) Message-ID: <3a142e750806100902t7a2cddefp71eee2ea5eca55ae@mail.gmail.com> Date: Tue, 10 Jun 2008 18:02:55 +0200 From: "Paul B. Mahol" To: "Coleman Kane" In-Reply-To: <1213102786.1547.3.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1212870158.1724.25.camel@localhost> <3a142e750806071855wb9f4cddk9be25e8c0f3d4984@mail.gmail.com> <1213013020.25641.3.camel@localhost> <1213026755.1628.25.camel@localhost> <3a142e750806092016u34fcd515v7022aa6a0a034e17@mail.gmail.com> <1213101246.1588.5.camel@localhost> <3a142e750806100556q546df348j4d5cb06bfe2bf286@mail.gmail.com> <1213102786.1547.3.camel@localhost> Cc: freebsd-current@freebsd.org, thompsa@freebsd.org Subject: Re: Call for Testers: Convert watchdog spinlock into a sleepable mutex in if_ndis X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2008 16:02:56 -0000 Works fine for me. No regressions encountered yet. On 6/10/08, Coleman Kane wrote: > On Tue, 2008-06-10 at 14:56 +0200, Paul B. Mahol wrote: >> On 6/10/08, Coleman Kane wrote: >> > On Tue, 2008-06-10 at 05:16 +0200, Paul B. Mahol wrote: >> >> On 6/9/08, Coleman Kane wrote: >> >> > Ignore the previous patch (#2) and try this one instead: >> >> > * >> >> > http://people.freebsd.org/~cokane/patches/if_ndis-spinlock-to-mtx3.patch >> >> > >> >> >> >> Fine for me, LOR appear any more. >> > >> > Thanks for the report. >> > >> >> >> >> BTW: I'm dont like first line showing over and over again. It would be >> >> nice >> >> if that clueless message goes away. >> > >> > Is this a new message introduced with my changes? >> No, it is not. Thanks for patch(es). >> > > I've got one more for you to try: > * > http://people.freebsd.org/~cokane/patches/if_ndis-spinlock-to-mtx4.patch > > It removes the locking inside the ndis_tick function altogether, and > just relies upon ndis_ticktask, ndis_resettask, and ndis_starttask to > perform the appropriate locking (which they appear to have been written > to do already). This might improve concurrency even more (and probably > get rid of some mutex recursions). > > -- > Coleman Kane >