From owner-freebsd-ports@FreeBSD.ORG  Wed May  4 01:17:49 2005
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 56C5616A4CE
	for <ports@freebsd.org>; Wed,  4 May 2005 01:17:49 +0000 (GMT)
Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at
	[128.131.111.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ED5B643D8B
	for <ports@freebsd.org>; Wed,  4 May 2005 01:17:48 +0000 (GMT)
	(envelope-from gerald@pfeifer.com)
Received: from [128.131.111.60] (acrux [128.131.111.60])
	by vexpert.dbai.tuwien.ac.at (Postfix) with ESMTP
	id 7F5561378F; Wed,  4 May 2005 03:17:47 +0200 (CEST)
Date: Wed, 4 May 2005 03:17:55 +0200 (CEST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Edwin Groothuis <edwin@mavetju.org>
In-Reply-To: <20050504010128.GN1175@k7.mavetju>
Message-ID: <Pine.BSF.4.62.0505040310560.76590@acrux.dbai.tuwien.ac.at>
References: <Pine.BSF.4.62.0505040238130.76590@acrux.dbai.tuwien.ac.at>
 <20050504010128.GN1175@k7.mavetju>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: ports@freebsd.org
Subject: Re: How to set CONFLICTS properly?
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 May 2005 01:17:49 -0000

On Wed, 4 May 2005, Edwin Groothuis wrote:
>>   # CONFLICTS - A list of package name patterns that the port conflicts with.
>>   #             It's possible to use any shell meta-characters for pattern
>>   #             matching.
>>   #             E.g. apache*-1.2* apache*-1.3.[012345] apache-*+ssl_*
>> 
>> However, CONFLICTS= {gcc-3.3.*,gcc-4.1.*}* fails to detect an installed 
>> gcc-3.3.6_20050427 port, whereas `ls $PKG_DBDIR/gcc-{3.3.*,4.1.*}` does
>> indeed find the directory in the database.
>> 
>> Why doesn't that CONFLICTS statement work?
> CONFLICTS=      gcc-3.4* gcc-4.1*

That gave me the necessary hint: shell meta-characters above refers to
BSD /bin/sh, not tcsh nor GNU /bin/sh (alias bash), and while the latter
two support {...,...}, BSD /bin/sh does not.

Any comments on the patch below, before I send-pr it to portmgr?

Gerald

Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.511
diff -u -3 -p -r1.511 bsd.port.mk
--- bsd.port.mk	17 Mar 2005 23:22:07 -0000	1.511
+++ bsd.port.mk	4 May 2005 01:17:06 -0000
@@ -468,10 +468,10 @@ FreeBSD_MAINTAINER=	portmgr@FreeBSD.org
 # Conflict checking.  Use if your port cannot be installed at the same time as
 # another package.
 #
-# CONFLICTS		- A list of package name patterns that the port conflicts with.
-#				  It's possible to use any shell meta-characters for pattern
-#				  matching.
-#				  E.g. apache*-1.2* apache*-1.3.[012345] apache-*+ssl_*
+# CONFLICTS		- A list of package name patterns that the port conflicts
+#				  with, separated by blanks.  It's possible to use shell
+#				  meta-characters "*", "?", "[" and "!" for pattern matching.
+#				  Example: apache*-1.2* apache*-1.3.[012345] apache-*+ssl_*
 #
 # Various directory definitions and variables to control them.
 # You rarely need to redefine any of these except WRKSRC and NO_WRKSUBDIR.